From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbbFNMYb (ORCPT ); Sun, 14 Jun 2015 08:24:31 -0400 Received: from the.earth.li ([46.43.34.31]:47836 "EHLO the.earth.li" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbbFNMYX (ORCPT ); Sun, 14 Jun 2015 08:24:23 -0400 Date: Sun, 14 Jun 2015 13:24:20 +0100 From: Jonathan McDowell To: Takashi Iwai Cc: Mihai =?utf-8?B?RG9uyJt1?= , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: Audio crackles with 4.1-rc1 Message-ID: <20150614122420.GT28070@earth.li> References: <20150610194303.3b82609d@mdontu-l.dsd.bitdefender.biz> <20150611011236.53bcd1fd@mdontu-l> <20150612012318.6e3482ed@mdontu-l> <20150612124523.37fd0875@mdontu-l> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 12, 2015 at 04:13:16PM +0200, Takashi Iwai wrote: > At Fri, 12 Jun 2015 12:09:55 +0200, > Takashi Iwai wrote: > > At Fri, 12 Jun 2015 12:45:23 +0300, > > Mihai Donțu wrote: > > > Nice shot! It appears to work. :-) No clicks, no static. > > > > Good to hear! > > > > > I had to apply it by hand over 4.1-rc7, because the first two arrays > > > look different in both it and -master. Anyway, I will play with it some > > > more today see if anything else is broken. > > > > While we are at it: could you try to enable codec->power_save_node in > > patch_alc269() (while keeping the new patch)? > > > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -5671,8 +5671,7 @@ static int patch_alc269(struct hda_codec *codec) > > > > spec = codec->spec; > > spec->gen.shared_mic_vref_pin = 0x18; > > - if (codec->core.vendor_id != 0x10ec0292) > > - codec->power_save_node = 1; > > + codec->power_save_node = 1; > > > > #ifdef CONFIG_PM > > codec->patch_ops.suspend = alc269_suspend; > > For your convenience, below is the combined patch for 4.1. > > Jonathan, could you also try this patch and see whether you still get > the noise? Applying the combined patch to 4.1-rc7 I'm not getting any noise on the transition from suspended to active. J. -- 101 things you can't have too | .''`. Debian GNU/Linux Developer much of : 47 - More coffee. | : :' : Happy to accept PGP signed | `. `' or encrypted mail - RSA | `- key on the keyservers.