From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752061AbbFYS1o (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Jun 2015 14:27:44 -0400
Received: from e28smtp02.in.ibm.com ([122.248.162.2]:54793 "EHLO
	e28smtp02.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751469AbbFYS1g (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Jun 2015 14:27:36 -0400
X-Helo: d28dlp01.in.ibm.com
X-MailFrom: naveen.n.rao@linux.vnet.ibm.com
X-RcptTo: linux-kernel@vger.kernel.org
Date: Thu, 25 Jun 2015 23:57:07 +0530
From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Balbir Singh <bsingharora@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] proc/schedstat: Expose /proc/<pid>/schedstat if delay
 accounting is enabled
Message-ID: <20150625182707.GA15883@naverao1-tp.in.ibm.com>
References: <1432537954-26665-1-git-send-email-naveen.n.rao@linux.vnet.ibm.com>
 <CAKTCnzm5A6n=jvskHqUmpdq7yynzKqwuVFJL-ia=3PmgDeBV-w@mail.gmail.com>
 <CAM_iQpW8+pHOhdnZS7iwE987Qc1AqX0qCRYPvEZx5Xc8Ep+92w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAM_iQpW8+pHOhdnZS7iwE987Qc1AqX0qCRYPvEZx5Xc8Ep+92w@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 15062518-0005-0000-0000-00000616AF4E
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2015/06/25 11:00AM, Cong Wang wrote:
> On Thu, May 28, 2015 at 2:11 AM, Balbir Singh <bsingharora@gmail.com> wrote:
> > On Mon, May 25, 2015 at 12:42 PM, Naveen N. Rao
> > <naveen.n.rao@linux.vnet.ibm.com> wrote:
> >> /proc/<pid>/schedstat is currently only available if CONFIG_SCHEDSTATS is
> >> enabled. But, all the fields that this exposes are available and valid
> >> if CONFIG_TASK_DELAY_ACCT is enabled as well.
> >>
> 
> [...]
> 
> > The change looks reasonable, from what I can understand you want these
> > changes so that you can use /proc/<pid>/schedstat instead of the
> > netlink interface when CONFIG_TASK_DELAY_ACCT is enabled.
> >
> 
> Why?
> 
> If you need the procfs interface, just enable CONFIG_SCHEDSTATS.
> If you need the netlink interface, enable CONFIG_TASK_DELAY_ACCT.
> They are just two different interfaces for getting the same sched
> information, so why make this change?
> 
> There must be some reason you don't want to enable
> CONFIG_SCHEDSTATS? If so, please add it in the changelog.
> 
> My guess is it depends on DEBUG_KERNEL which is not what you
> want? But I see no reason it should have that dependency, it just
> exposes some stats, looks like can be just removed (and moved out
> of Kconfig,debug of course).

The primary issue with CONFIG_SCHEDSTATS is the (slight) additional 
overhead it introduces, per Kconfig. Due to this, it is not enabled by 
default by some of the distro kernels.

Regards,
Naveen