From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751962AbbFZXEL (ORCPT ); Fri, 26 Jun 2015 19:04:11 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:52574 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940AbbFZXED (ORCPT ); Fri, 26 Jun 2015 19:04:03 -0400 Date: Fri, 26 Jun 2015 16:04:02 -0700 From: Darren Hart To: SF Markus Elfring Cc: platform-driver-x86@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] tc1100-wmi: Delete an unnecessary check before the function call "kfree" Message-ID: <20150626230402.GA57818@vmdeb7> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <558DA7C8.6060003@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <558DA7C8.6060003@users.sourceforge.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 26, 2015 at 09:28:08PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 26 Jun 2015 21:21:16 +0200 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Queued, thanks. -- Darren Hart Intel Open Source Technology Center