From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752435AbbFZXHd (ORCPT ); Fri, 26 Jun 2015 19:07:33 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:52649 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752130AbbFZXH0 (ORCPT ); Fri, 26 Jun 2015 19:07:26 -0400 Date: Fri, 26 Jun 2015 16:06:55 -0700 From: Darren Hart To: Julia Lawall Cc: SF Markus Elfring , Anisse Astier , Corentin Chary , Ike Panhc , Jonathan Woithe , Mattia Dongili , platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister() Message-ID: <20150626230655.GB57818@vmdeb7> References: <5307CAA2.8060406@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547389A6.9090106@users.sourceforge.net> <3842367.ojrMxTW2rH@path> <5473AD39.9010309@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 27, 2014 at 07:13:10PM +0100, Julia Lawall wrote: > > > On Mon, 24 Nov 2014, SF Markus Elfring wrote: > > > >> This issue was detected by using the Coccinelle software. > > > > > > What script was used ? > > > > A semantic patch approach which I published on the mailing lists in March > > is in action on my software development system for a while. > > > > > > > Is it in scripts/coccinelle ? > > > > Not yet. > > > > I hope that the involved update suggestions got sufficient positive feedback > > to integrate five scripts there. > > The current scripts are very complicated, involving the interaction > between multiple scripts and a database, and I think they are not very > suitable for make coccicheck. Also, the idea of removing the null checks > is not appropriate in all contexts. Perhaps it could be possible to add > a script to the Linux kernel that handles a number of common cases for > which removing the null test is widely considered to be desirable. > > julia > Julia, do you have any particular objection to this specific patch? I didn't see a reason to prevent it going in. -- Darren Hart Intel Open Source Technology Center