From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752491AbbF2VrL (ORCPT ); Mon, 29 Jun 2015 17:47:11 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:51812 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbbF2VrD (ORCPT ); Mon, 29 Jun 2015 17:47:03 -0400 Date: Mon, 29 Jun 2015 16:47:01 -0500 From: Felipe Balbi To: Subbaraya Sundeep Bhatta CC: , , , , , Subbaraya Sundeep Bhatta Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails Message-ID: <20150629214701.GK1019@saruman.tx.rr.com> Reply-To: References: <1432203408-5482-1-git-send-email-sbhatta@xilinx.com> <1432203408-5482-3-git-send-email-sbhatta@xilinx.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NPWyolIJAVLYbHY6" Content-Disposition: inline In-Reply-To: <1432203408-5482-3-git-send-email-sbhatta@xilinx.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NPWyolIJAVLYbHY6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote: > We need to return error to caller if command is not sent to > controller succesfully. >=20 > Signed-off-by: Subbaraya Sundeep Bhatta > Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver) > Cc: > --- > v2 changes: > Added Fixes and Cc in commit message. I noticed that this breaks at least my AM437x silicon with DWC3 2.40a when used with g_zero and testusb. As of now, it could be that silicon is mis-behaving because I got a Transfer Complete before the failing Set Endpoint Transfer Resource command. In any case, can you run on your setup with g_zero and test.sh/testusb [1]/[2] just to verify that it really works for you ? Meanwhile, I'll continue testing on my end. cheers [1] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c81374= aafb795c6e40:testusb.c [2] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c81374= aafb795c6e40:test.sh --=20 balbi --NPWyolIJAVLYbHY6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVkbzVAAoJEIaOsuA1yqRETwcQAJq6YfkBcDlDpLK7mFZO9/1r yTjgVQRl2JAvjD5coygG0VLSCM+F/rme/1TsjSj+B54aOc9rKyyBK825Oxw9he11 y9ObLbuukojZ/x8rb2XYM0M8dP/Dtj06btQ65k+hRR+uMxvWSpLjGtwsXw6kb7Zi LacD/sTLdQ6l+lxITydOY3Yu4PiGUfld5su6KxYL4XFG6xzbSvi5ywqznu3xubf3 9AA5mb2+E6xIWQtnyivm/be93yitw20d7KyXEPdrNpyvYb0/adzPiseWXesezvZC sDsLL37fUaHjqv8QCoPUQTZUDkPHjJn/p6aTkhrU4/7/DGkUkwuFZgZWEL/LY5Vs F/EhVwyKbEvOfKu+5cvhJnoHFzGiXFDpQRopBCPHTM8rjGL7HP7GQz5SMX2gJGcH 4RJNMNsI6Ceq5wpwUxhQE/fPwDf7YuDe+AvoAnxCPgy+sM8UmeqjUNNwJHsn8JPP /dkjtNkf6GFi+NztAYnqNcVmitDlkT2LlQPS4QSUPCGB9K6IFrvJJThMZxYCm3wa b8WZDU93aak07pvtdq7RmWIfpwb60p3mNqgLqB1FRSqCE8yCZRBT1qN/42ZuVskc 1m/DUbZqxajg7QYwHWxp+r7LPl7UaPuL9ZbA/2X3TBkBygw5LYMsNOR6DSTfaqAC xo6cLV37UIu6Nu64/ibg =saJ9 -----END PGP SIGNATURE----- --NPWyolIJAVLYbHY6--