Re: [PATCH v4 07/17] x86/traps: Assert that we're in CONTEXT_KERNEL in exception entries

From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "Andy Lutomirski" <luto@kernel.org>, "X86 ML" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Rik van Riel" <riel@redhat.com>,
	"Oleg Nesterov" <oleg@redhat.com>,
	"Denys Vlasenko" <vda.linux@googlemail.com>,
	"Kees Cook" <keescook@chromium.org>,
	"Brian Gerst" <brgerst@gmail.com>,
	"Paul McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH v4 07/17] x86/traps: Assert that we're in CONTEXT_KERNEL in exception entries
Date: Tue, 30 Jun 2015 19:15:24 +0200	[thread overview]
Message-ID: <20150630171524.GG23297@pd.tnic> (raw)
In-Reply-To: <CALCETrVZhndKc9yRi6rRDYasCpTjdVGQ0KDPfuF6+q0VnJr9Ug@mail.gmail.com>

On Tue, Jun 30, 2015 at 10:08:00AM -0700, Andy Lutomirski wrote:
> I would agree, except that I remove the exception_enter calls later in
> the series, so that wouldn't work.

Ah.

> Maybe we should move them into common code outside the specific
> exception handlers (idtentry?) when the dust settles.

Yeah, that macro is huge but it could survive yet another CALL <func>.

:-)

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--