From: Mark Brown <broonie@kernel.org>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
cooloney@gmail.com, rpurdie@rpsys.net,
stsp@users.sourceforge.net, pavel@ucw.cz,
sakari.ailus@linux.intel.com, andreas.werner@men.de,
andrew@lunn.ch, ospite@studenti.unina.it, anemo@mba.ocn.ne.jp,
ben@simtec.co.uk, bootc@bootc.net, dmurphy@ti.com,
daniel.jeong@ti.com, daniel@zonque.org, davem@davemloft.net,
fabio.baltieri@gmail.com, balbi@ti.com, florian@openwrt.org,
gshark.jeong@gmail.com, g.liakhovetski@gmx.de,
ingi2.kim@samsung.com, dl9pf@gmx.de, johan@kernel.org,
lenz@cs.wisc.edu, jogo@openwrt.org, q1.kim@samsung.com,
kris@krisk.org, kristoffer.ericson@gmail.com,
linus.walleij@linaro.org, michael.hennerich@analog.com,
milo.kim@ti.com, nm127@freemail.hu, ncase@xes-inc.com,
neilb@suse.de, nick.forbes@incepta.com, lost.distance@yahoo.com,
p.meerwald@bct-electronic.com, n0-1@freewrt.org,
philippe.retornaz@epfl.ch, raph@8d.com, rpurdie@openedhand.com,
rod@whitby.id.au, dave@sr71.net, giometti@linux.it,
bigeasy@linutronix.de, shuahkhan@gmail.com, sguinot@lacie.com
Subject: Re: [PATCH/RFC v2 1/5] leds: Use set_brightness_work for brightness_set ops that can sleep
Date: Wed, 1 Jul 2015 10:42:58 +0100 [thread overview]
Message-ID: <20150701094258.GS11162@sirena.org.uk> (raw)
In-Reply-To: <20150630222450.GR5904@valkosipuli.retiisi.org.uk>
[-- Attachment #1: Type: text/plain, Size: 446 bytes --]
On Wed, Jul 01, 2015 at 01:24:50AM +0300, Sakari Ailus wrote:
> The documentation should be improved to tell how the API is expected to be
> have, e.g. which functions may block. I think this is out of scope for this
> patch though.
> I think all the existing drivers that implement the set_brightness()
> callback have a fast (and non-blocking) implementation, and some of these
Yes, they need to be since triggers can happen in any context.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-07-01 9:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 13:59 [PATCH/RFC v2 1/5] leds: Use set_brightness_work for brightness_set ops that can sleep Jacek Anaszewski
2015-06-30 13:59 ` [PATCH/RFC v2 2/5] leds: pwm: remove work queue Jacek Anaszewski
2015-06-30 13:59 ` [PATCH/RFC v2 3/5] led: flash: remove check for brightness_set_sync op Jacek Anaszewski
2015-06-30 13:59 ` [PATCH/RFC v2 4/5] leds: max77693: remove work queue Jacek Anaszewski
2015-06-30 13:59 ` [PATCH/RFC v2 5/5] leds: aat1290: " Jacek Anaszewski
2015-06-30 18:30 ` [PATCH/RFC v2 1/5] leds: Use set_brightness_work for brightness_set ops that can sleep Pavel Machek
2015-06-30 22:24 ` Sakari Ailus
2015-07-01 9:42 ` Mark Brown [this message]
2015-07-01 9:52 ` Jacek Anaszewski
2015-07-01 12:01 ` Jacek Anaszewski
2015-07-01 21:44 ` Sakari Ailus
2015-07-03 13:16 ` Jacek Anaszewski
2015-07-01 21:36 ` Sakari Ailus
2015-07-01 22:56 ` Andrew Lunn
2015-07-03 13:16 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150701094258.GS11162@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andreas.werner@men.de \
--cc=andrew@lunn.ch \
--cc=anemo@mba.ocn.ne.jp \
--cc=balbi@ti.com \
--cc=ben@simtec.co.uk \
--cc=bigeasy@linutronix.de \
--cc=bootc@bootc.net \
--cc=cooloney@gmail.com \
--cc=daniel.jeong@ti.com \
--cc=daniel@zonque.org \
--cc=dave@sr71.net \
--cc=davem@davemloft.net \
--cc=dl9pf@gmx.de \
--cc=dmurphy@ti.com \
--cc=fabio.baltieri@gmail.com \
--cc=florian@openwrt.org \
--cc=g.liakhovetski@gmx.de \
--cc=giometti@linux.it \
--cc=gshark.jeong@gmail.com \
--cc=ingi2.kim@samsung.com \
--cc=j.anaszewski@samsung.com \
--cc=jogo@openwrt.org \
--cc=johan@kernel.org \
--cc=kris@krisk.org \
--cc=kristoffer.ericson@gmail.com \
--cc=lenz@cs.wisc.edu \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lost.distance@yahoo.com \
--cc=michael.hennerich@analog.com \
--cc=milo.kim@ti.com \
--cc=n0-1@freewrt.org \
--cc=ncase@xes-inc.com \
--cc=neilb@suse.de \
--cc=nick.forbes@incepta.com \
--cc=nm127@freemail.hu \
--cc=ospite@studenti.unina.it \
--cc=p.meerwald@bct-electronic.com \
--cc=pavel@ucw.cz \
--cc=philippe.retornaz@epfl.ch \
--cc=q1.kim@samsung.com \
--cc=raph@8d.com \
--cc=rod@whitby.id.au \
--cc=rpurdie@openedhand.com \
--cc=rpurdie@rpsys.net \
--cc=sakari.ailus@iki.fi \
--cc=sakari.ailus@linux.intel.com \
--cc=sguinot@lacie.com \
--cc=shuahkhan@gmail.com \
--cc=stsp@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).