From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755822AbbGCQ2f (ORCPT ); Fri, 3 Jul 2015 12:28:35 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:48201 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756046AbbGCQ2V (ORCPT ); Fri, 3 Jul 2015 12:28:21 -0400 Date: Fri, 03 Jul 2015 09:28:19 -0700 (PDT) Message-Id: <20150703.092819.95179652477512417.davem@davemloft.net> To: elfring@users.sourceforge.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] netlink: Delete an unnecessary check before the function call "module_put" From: David Miller In-Reply-To: <55956AC1.9000902@users.sourceforge.net> References: <5317A59D.4@users.sourceforge.net> <55956AC1.9000902@users.sourceforge.net> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 03 Jul 2015 09:28:19 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: SF Markus Elfring Date: Thu, 02 Jul 2015 18:45:53 +0200 > From: Markus Elfring > Date: Thu, 2 Jul 2015 18:38:12 +0200 > > The module_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied.