From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754791AbbGCI42 (ORCPT ); Fri, 3 Jul 2015 04:56:28 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:36270 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbbGCI4Y (ORCPT ); Fri, 3 Jul 2015 04:56:24 -0400 Date: Fri, 3 Jul 2015 14:26:19 +0530 From: Viresh Kumar To: Daniel Lezcano Cc: Thomas Gleixner , linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Tang Subject: Re: [PATCH 41/41] clocksource: zevio: Migrate to new 'set-state' interface Message-ID: <20150703085619.GD23297@linux> References: <2492473d6bb8f057af389d6db24af77462af2468.1434622147.git.viresh.kumar@linaro.org> <55959B0F.5000306@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55959B0F.5000306@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02-07-15, 22:11, Daniel Lezcano wrote: > On 06/18/2015 12:54 PM, Viresh Kumar wrote: > >Migrate zevio driver to the new 'set-state' interface provided by > >clockevents core, the earlier 'set-mode' interface is marked obsolete > >now. > > > >This also enables us to implement callbacks for new states of clockevent > >devices, for example: ONESHOT_STOPPED. > > > >Cc: Daniel Tang > >Signed-off-by: Viresh Kumar > >--- > > [ ... ] > > > static irqreturn_t zevio_timer_interrupt(int irq, void *dev_id) > >@@ -162,7 +158,9 @@ static int __init zevio_timer_add(struct device_node *node) > > if (timer->interrupt_regs && irqnr) { > > timer->clkevt.name = timer->clockevent_name; > > timer->clkevt.set_next_event = zevio_timer_set_event; > >- timer->clkevt.set_mode = zevio_timer_set_mode; > >+ timer->clkevt.set_state_shutdown = zevio_timer_shutdown; > >+ timer->clkevt.set_state_oneshot = zevio_timer_set_oneshot; > >+ timer->clkevt.tick_resume = zevio_timer_set_oneshot; > > Why is tick_resume added here ? I am assuming you are lost because of reviewing too many similar patches, but anyway below was part of the diff and so resume was required :) - switch (mode) { - case CLOCK_EVT_MODE_RESUME: - case CLOCK_EVT_MODE_ONESHOT: - /* Enable timer interrupts */ - writel(TIMER_INTR_MSK, timer->interrupt_regs + IO_INTR_MSK); - writel(TIMER_INTR_ALL, timer->interrupt_regs + IO_INTR_ACK); - break; -- viresh