From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754812AbbGFIzK (ORCPT ); Mon, 6 Jul 2015 04:55:10 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:26530 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754785AbbGFIzF (ORCPT ); Mon, 6 Jul 2015 04:55:05 -0400 Date: Mon, 6 Jul 2015 11:54:15 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: Joel Becker , Mark Fasheh , ocfs2-devel@oss.oracle.com, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 03/11] ocfs2: Less checks in ocfs2_rename() after error detection Message-ID: <20150706085414.GD28762@mwanda> References: <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5455FC05.4010606@users.sourceforge.net> <55992DF0.5030205@users.sourceforge.net> <55993170.6060306@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55993170.6060306@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 05, 2015 at 03:30:24PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 4 Jul 2015 15:30:18 +0200 > > Skip checks for a few variables in three error handling cases within > the ocfs2_rename() function by adjustment of a few jump targets > according to the Linux coding style convention. > > Signed-off-by: Markus Elfring I don't think this is an improvement. regards, dan carpenter