From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754772AbbGFL1w (ORCPT ); Mon, 6 Jul 2015 07:27:52 -0400 Received: from casper.infradead.org ([85.118.1.10]:44823 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751925AbbGFL1u (ORCPT ); Mon, 6 Jul 2015 07:27:50 -0400 Date: Mon, 6 Jul 2015 13:27:46 +0200 From: Peter Zijlstra To: byungchul.park@lge.com Cc: mingo@kernel.org, minchan.kim@lge.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] sched: apply ifdef CONFIG_SMP to meaningful code only on SMP system Message-ID: <20150706112746.GD3644@twins.programming.kicks-ass.net> References: <1436089411-27244-1-git-send-email-byungchul.park@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436089411-27244-1-git-send-email-byungchul.park@lge.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 05, 2015 at 06:43:31PM +0900, byungchul.park@lge.com wrote: > From: Byungchul Park > > account_numa_dequeue and manipulating se->group_node are meaningful only on SMP Clearly the data element exists for !SMP and you didn't fix that. Also, try and do this without adding more #ifdef.