From: Shawn Guo <shawnguo@kernel.org>
To: Philippe Reynes <tremyfr@gmail.com>
Cc: a.zummo@towertech.it, alexandre.belloni@free-electrons.com,
shawn.guo@linaro.org, kernel@pengutronix.de,
linux@arm.linux.org.uk, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 6/7] imx27: dt: add support of internal rtc
Date: Thu, 9 Jul 2015 22:32:57 +0800 [thread overview]
Message-ID: <20150709143257.GJ23464@tiger> (raw)
In-Reply-To: <1435965320-1478-7-git-send-email-tremyfr@gmail.com>
On Sat, Jul 04, 2015 at 01:15:19AM +0200, Philippe Reynes wrote:
> Add support of internal rtc on imx27.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
> ---
> arch/arm/boot/dts/imx27.dtsi | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> index b69be5c..38e6e84 100644
> --- a/arch/arm/boot/dts/imx27.dtsi
> +++ b/arch/arm/boot/dts/imx27.dtsi
> @@ -144,6 +144,16 @@
> clock-names = "ipg", "per";
> };
>
> + rtc: rtc@10007000 {
> + compatible = "fsl,imx21-rtc";
> + reg = <0x10007000 0x1000>;
> + interrupts = <22>;
> + clocks = <&clks IMX27_CLK_CKIL>,
> + <&clks IMX27_CLK_RTC_IPG_GATE>;
> + clock-names = "rtc", "ipg";
> + status = "disabled";
It has neither pin-out nor board level configuration. For such device,
it makes more sense to drop status = "disabled" and enable the device by
default. The bonus point would be that patch #7 in the series can be
saved.
Shawn
> + };
> +
> kpp: kpp@10008000 {
> compatible = "fsl,imx27-kpp", "fsl,imx21-kpp";
> reg = <0x10008000 0x1000>;
> --
> 1.7.4.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2015-07-09 14:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 23:15 [PATCH v4 0/7] add device tree support for mxc rtc Philippe Reynes
2015-07-03 23:15 ` [PATCH v4 1/7] imx31: add a second rtc clock Philippe Reynes
2015-07-03 23:15 ` [PATCH v4 2/7] imx35: define two clocks for rtc Philippe Reynes
2015-07-03 23:15 ` [PATCH v4 3/7] rtc: mxc: use a second rtc clock Philippe Reynes
2015-07-14 21:49 ` [rtc-linux] " Alexandre Belloni
2015-07-03 23:15 ` [PATCH v4 4/7] rtc: mxc: add support of device tree Philippe Reynes
2015-07-14 21:52 ` [rtc-linux] " Alexandre Belloni
2015-07-03 23:15 ` [PATCH v4 5/7] dt-binding: document the binding for mxc rtc Philippe Reynes
2015-07-09 14:26 ` Shawn Guo
2015-07-10 19:58 ` Rob Herring
2015-07-03 23:15 ` [PATCH v4 6/7] imx27: dt: add support of internal rtc Philippe Reynes
2015-07-09 14:32 ` Shawn Guo [this message]
2015-07-03 23:15 ` [PATCH v4 7/7] apf27: dt: enable " Philippe Reynes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709143257.GJ23464@tiger \
--to=shawnguo@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rtc-linux@googlegroups.com \
--cc=shawn.guo@linaro.org \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).