From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 21/22] staging: rtl8192e: Make rtllib_rx_mgt() static
Date: Mon, 13 Jul 2015 12:49:18 +0530 [thread overview]
Message-ID: <20150713071918.GA7984@sudip-PC> (raw)
In-Reply-To: <1436732972-30175-22-git-send-email-mateusz.kulikowski@gmail.com>
On Sun, Jul 12, 2015 at 10:29:31PM +0200, Mateusz Kulikowski wrote:
> Function is not referenced outside of rtllib_rx.c
>
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib.h | 3 ---
> drivers/staging/rtl8192e/rtllib_rx.c | 10 +++++++---
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 5c71dc0..75541c2 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -2006,9 +2006,6 @@ extern void rtllib_txb_free(struct rtllib_txb *);
> /* rtllib_rx.c */
> extern int rtllib_rx(struct rtllib_device *ieee, struct sk_buff *skb,
> struct rtllib_rx_stats *rx_stats);
> -extern void rtllib_rx_mgt(struct rtllib_device *ieee,
> - struct sk_buff *skb,
> - struct rtllib_rx_stats *stats);
> extern void rtllib_rx_probe_rq(struct rtllib_device *ieee,
> struct sk_buff *skb);
> extern int rtllib_legal_channel(struct rtllib_device *rtllib, u8 channel);
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index da862c3..82dec38 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -44,6 +44,10 @@
> #include "rtllib.h"
> #include "dot11d.h"
>
> +
this introduces a new checkpatch warning about multiple blank lines.
regards
sudip
next prev parent reply other threads:[~2015-07-13 7:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 20:29 [PATCH 00/22] staging: rtl8192e: Various cleanups Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 01/22] staging: rtl8192e: Remove ToLegalChannel() Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 02/22] staging: rtl8192e: Remove unused defines Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 03/22] staging: rtl8192e: Remove undefs Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 04/22] staging: rtl8192e: Remove unused enums Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 05/22] staging: rtl8192e: Remove unused fields from rtllib_stats Mateusz Kulikowski
2015-07-13 12:01 ` Dan Carpenter
2015-07-12 20:29 ` [PATCH 06/22] staging: rtl8192e: Remove unused ether_header structure Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 07/22] staging: rtl8192e: Remove unused rtllib_device::freq_band Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 08/22] staging: rtl8192e: Remove DOT11D_GetMaxTxPwrInDbm() Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 09/22] staging: rtl8192e: Remove read|write_nic_io_(d)word|byte() Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 10/22] staging: rtl8192e: Remove DMESG macro Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 11/22] staging: rtl8192e: Remove rtl819x_process_cck_rxpathsel() Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 12/22] staging: rtl8192e: probe: Remove bdma64 check Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 13/22] staging: rtl8192e: Remove rtl8192_rx_cmd() Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 14/22] staging: rtl8192e: rtl_dm: Make functions static Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 15/22] staging: rtl8192e: rtllib_HTProc: " Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 16/22] staging: rtl8192e: Make phy_RF8256_Config_ParaFile() static Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 17/22] staging: rtl8192e: rtl_core: Make functions static Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 18/22] staging: rtl8192e: r8192e_phy: " Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 19/22] staging: rtl8192e: Make rtl8192_QueryIsShort() static Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 20/22] staging: rtl8192e: rtllib_tx: Make functions static Mateusz Kulikowski
2015-07-12 20:29 ` [PATCH 21/22] staging: rtl8192e: Make rtllib_rx_mgt() static Mateusz Kulikowski
2015-07-13 7:19 ` Sudip Mukherjee [this message]
2015-07-12 20:29 ` [PATCH 22/22] staging: rtl8192e: rtllib_softmac: Make functions static Mateusz Kulikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713071918.GA7984@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.kulikowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).