From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752939AbbGMS7F (ORCPT ); Mon, 13 Jul 2015 14:59:05 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:60177 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbbGMS7D (ORCPT ); Mon, 13 Jul 2015 14:59:03 -0400 Date: Mon, 13 Jul 2015 13:58:57 -0500 From: Felipe Balbi To: John Youn CC: "balbi@ti.com" , Subbaraya Sundeep Bhatta , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails Message-ID: <20150713185857.GD32056@saruman.tx.rr.com> Reply-To: References: <1432203408-5482-3-git-send-email-sbhatta@xilinx.com> <20150629214701.GK1019@saruman.tx.rr.com> <20150629214854.GL1019@saruman.tx.rr.com> <2B3535C5ECE8B5419E3ECBE3007729090175264F3B@US01WEMBX2.internal.synopsys.com> <20150702030009.GB29462@saruman.tx.rr.com> <2B3535C5ECE8B5419E3ECBE3007729090175267F20@US01WEMBX2.internal.synopsys.com> <20150707032448.GB13135@saruman.tx.rr.com> <20150711192914.GA24195@saruman.tx.rr.com> <2B3535C5ECE8B5419E3ECBE3007729090175270D38@US01WEMBX2.internal.synopsys.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6Nae48J/T25AfBN4" Content-Disposition: inline In-Reply-To: <2B3535C5ECE8B5419E3ECBE3007729090175270D38@US01WEMBX2.internal.synopsys.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6Nae48J/T25AfBN4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Jul 13, 2015 at 05:50:49PM +0000, John Youn wrote: > On 7/11/2015 12:29 PM, Felipe Balbi wrote: > > Hi, > >=20 > > On Sat, Jul 11, 2015 at 05:17:32PM +0000, Subbaraya Sundeep Bhatta wrot= e: > >>>>>> Hi Felipe, > >>>>>> > >>>>>> Just an update on this. > >>>>>> > >>>>>> I'm trying to get this working with our latest IP with dwc3 from > >>>>>> your testing/next branch. It fails the usbtest with a problem > >>>>>> unrelated to this patch. > >>>>>> . > >>>>>> It passes on 4.1.1. > >>>>>> > >>>>>> I'll have to look into the failure but I won't get to it until next > >>>>>> week as I'm off the rest of this week. > >>>>> > >>>>> interesting... If you could post failure signature, I can help > >>>>> looking at it, but I guess it's too late to ask :-) > >>>>> > >>>>> thanks for helping though > >>>>> > >>>> > >>>> > >>>> Hi Felipe, > >>>> > >>>> Nevermind about my issue, it ended up being a setup-related problem. > >>>> > >>>> I actually do see the same error as you due to this series of patche= s. > >>>> Except I see it happening before even the first iteration. I get a > >>>> completion status of 1 for the Set Endpoint Transfer Resources > >>>> command. I'm not sure why this is. > >>>> > >>>> I don't see any conflict with any previous Transfer Complete. > >> > >> Same behavior at my end too. Fails before first iteration and I get > >> completion status of 1 for Set Endpoint Resource command. Attached the > >> logs of testing done with this patch and without this patch. > >> Without this patch I often see completion status of 1 for Set Endpoint > >> Transfer Resources command for Bulk and Isoc endpoints but test > >> proceeds because driver just logs command completion status and moves > >> on. We can revert this patch for time being. IP version is 2.90a. > >=20 > > yeah, that's what I mean, it really seems like it's the IP misbehaving. > >=20 > > John, let's try to figure out what's the root cause of this, we really > > want to use command completion status at some point, but for now we need > > to revert the patch :-( > >=20 > > Let me know if you want me to log STARS ticket on your solvnet system. > >=20 > > cheers > >=20 >=20 > Hi Felipe, >=20 > We found the issue last week.=20 >=20 > The start config command isn't getting called during SET_INTERFACE. > Thus the transfer resource index isn't getting reset, and with > multiple SET_INTERFACE commands it will eventually exhaust the > resources. >=20 > I tried out a fix and it works for me. I'll send it out separately for > review. Thanks a lot John. Not sure how come we missed that for such a long time :-) Let's Cc stable and get it plugged ASAP :-) > Also, I noticed that the trace message that shows control transfers > doesn't show the SET_INTERFACE properly. Any idea why this is? >=20 > For example, here is the line in the trace that corresponds to the > SET_INTERFACE: > irq/33-dwc3-10808 [003] d... 2443.494368: dwc3_ctrl_req: bRequestType 01= bRequest 0b wValue 0001 wIndex 0000 wLength 0 I'll have a look at this when I'm back in the office (Jul 18th). --=20 balbi --6Nae48J/T25AfBN4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVpApxAAoJEIaOsuA1yqREoisQAKI2XPAU/jOXWMl0bZEItB2T 3TUWtDuLhix9uP8aieoarfVKV5pNOb8cKoZFkHYX94gFJstyczktLYG2uX7q/Xi1 8znFv03kcKwXazavLBje3Cy9eutpcYZ6pBLdn6jrv4i6ngTfrnN62qRYl9+jE0kG GV4+y2+C4BlJe1tmKU14hadWgWTMfbpzyJ8/WVhQp0W0tFTlkHdDpfw4Jpe103mB qHCw0j6WWQiE/iaUJm9BmvH5f3RA5XslV5J8BdoPhzj3QxIU82UNOL0csSHRI92i GpqEDfgRCiAlRGaQDmjYC7ZxX+Z52thwiozzZZZQzbDYFl29ILpEHoBCCAFDYuS0 FJdt9r3MFxJqMts+0leESdPD4f8AD0nOYz9k4s66VIyJuzU6lPz5jNtDEPRtgAb+ UjkxGw+vSEtX/Hj/jAAPRyUiQ5zDpmP0Gft8K/Y9wgTgwYobV3DD6rKkmecmK6Gu +dVc6k5z31NwLibi96mMxsbiJkvBtIe2NY38Ge2L4O8CsfCWSehuYK6CXz7DGAZX JCiKD6c+QeJ1AshiDffjuzLIrJHLZuvak3h2pWPK8rm12fHYhQyQBE7XdDqPpBmf JyqWGpiPpdcxhxZc17+sh43v0xZikSdpyHEfTUvLmrvgYvquzvAlxcAFzaB+tRy8 O+yJZZoHFZGYrMF7epCj =yw42 -----END PGP SIGNATURE----- --6Nae48J/T25AfBN4--