From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbbGSAao (ORCPT ); Sat, 18 Jul 2015 20:30:44 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:47120 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751988AbbGSAam (ORCPT ); Sat, 18 Jul 2015 20:30:42 -0400 Date: Sun, 19 Jul 2015 02:25:42 +0200 From: Ralf Baechle To: Paul Gortmaker Cc: Paul Burton , "linux-mips@linux-mips.org" , Matthew Fortune , Leonid Yegoshin , Michael Ellerman , LKML , Richard Weinberger , James Hogan , Andy Lutomirski , Markos Chandras , Manuel Lauss , "Maciej W. Rozycki" , "linux-next@vger.kernel.org" Subject: Re: [PATCH 04/16] MIPS: use struct mips_abi offsets to save FP context Message-ID: <20150719002542.GA5090@linux-mips.org> References: <1436540426-10021-1-git-send-email-paul.burton@imgtec.com> <1436540426-10021-5-git-send-email-paul.burton@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 18, 2015 at 08:21:53PM -0400, Paul Gortmaker wrote: > Date: Sat, 18 Jul 2015 20:21:53 -0400 > From: Paul Gortmaker > To: Paul Burton > Cc: "linux-mips@linux-mips.org" , Matthew > Fortune , Leonid Yegoshin > , Michael Ellerman , LKML > , Richard Weinberger , James > Hogan , Andy Lutomirski , > Markos Chandras , Ralf Baechle > , Manuel Lauss , "Maciej W. > Rozycki" , "linux-next@vger.kernel.org" > > Subject: Re: [PATCH 04/16] MIPS: use struct mips_abi offsets to save FP > context > Content-Type: text/plain; charset=UTF-8 > > On Fri, Jul 10, 2015 at 11:00 AM, Paul Burton wrote: > > When saving FP state to struct sigcontext, make use of the offsets > > provided by struct mips_abi to obtain appropriate addresses for the > > sc_fpregs & sc_fpc_csr fields of the sigcontext. This is done only for > > the native struct sigcontext in this patch (ie. for O32 in CONFIG_32BIT > > kernels or for N64 in CONFIG_64BIT kernels) but is done in preparation > > for sharing this code with compat ABIs in further patches. > > > > Signed-off-by: Paul Burton > > --- > > > > arch/mips/kernel/r4k_fpu.S | 151 +++++++++++++++++++++------------------ > > arch/mips/kernel/signal-common.h | 6 ++ > > arch/mips/kernel/signal.c | 85 +++++++++++++++------- > > 3 files changed, 145 insertions(+), 97 deletions(-) > > > > The current version of this in linux-next picked up a booger in transit. > > $ git show 6775b4ea74d5922e5310b7b7a902a8fbe61a0c9d|diffstat > arch/mips/kernel/r4k_fpu.S | 151 ++++++++++++++++++++------------------- > arch/mips/kernel/signal-common.h | 6 + > arch/mips/kernel/signal.c | 85 ++++++++++++++------- > index.html | 16 ++++ > 4 files changed, 161 insertions(+), 97 deletions(-) > > Guessing it happened at Ralf's end. Yes and I fixed a few hours ago. Should be ok in the next -next. Ralf