From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
vivien.didelot@savoirfairelinux.com,
jerome.oufella@savoirfairelinux.com, linux@roeck-us.net,
andrew@lunn.ch, cphealy@gmail.com, mathieu@codeaurora.org,
jonasj76@gmail.com, andrey.volkov@nexvision.fr,
Chris.Packham@alliedtelesis.co.nz
Subject: Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion
Date: Thu, 30 Jul 2015 15:51:24 -0700 (PDT) [thread overview]
Message-ID: <20150730.155124.2216613161860898066.davem@davemloft.net> (raw)
In-Reply-To: <20150730.141935.723435302404122784.davem@davemloft.net>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=iso-8859-7, Size: 1742 bytes --]
From: David Miller <davem@davemloft.net>
Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT)
> This looks fine, series applied, thanks.
I think your control block is too large, you'll need to rework this
somehow.
In function ¡dsa_copy_brcm_tag¢,
inlined from ¡bcm_sysport_desc_rx¢ at drivers/net/ethernet/broadcom/bcmsysport.c:707:4,
inlined from ¡bcm_sysport_poll¢ at drivers/net/ethernet/broadcom/bcmsysport.c:864:12:
include/linux/compiler.h:447:38: error: call to ¡__compiletime_assert_2016¢ declared with attribute error: BUILD_BUG_ON failed: sizeof(skb->cb) - sizeof(struct napi_gro_cb) < BRCM_TAG_LEN
_compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
^
include/linux/compiler.h:430:4: note: in definition of macro ¡__compiletime_assert¢
prefix ## suffix(); \
^
include/linux/compiler.h:447:2: note: in expansion of macro ¡_compiletime_assert¢
_compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
^
include/linux/bug.h:50:37: note: in expansion of macro ¡compiletime_assert¢
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^
include/linux/bug.h:74:2: note: in expansion of macro ¡BUILD_BUG_ON_MSG¢
BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
^
include/linux/netdevice.h:2016:2: note: in expansion of macro ¡BUILD_BUG_ON¢
BUILD_BUG_ON(sizeof(skb->cb) - sizeof(struct napi_gro_cb) < BRCM_TAG_LEN);
^
scripts/Makefile.build:264: recipe for target 'drivers/net/ethernet/broadcom/bcmsysport.o' failed
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
next prev parent reply other threads:[~2015-07-30 22:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 22:32 [PATCH net-next 0/3] net: Switch tag HW extraction/insertion Florian Fainelli
2015-07-29 22:32 ` [PATCH net-next 1/3] net: add flags for HW assisted extraction/insertions of switch tags Florian Fainelli
2015-07-29 22:32 ` [PATCH net-next 2/3] net: dsa: tag_brcm: Support extracting tags from HW Florian Fainelli
2015-07-29 22:32 ` [PATCH net-next 3/3] net: systemport: Add support for switch tag HW extraction Florian Fainelli
2015-07-30 21:19 ` [PATCH net-next 0/3] net: Switch tag HW extraction/insertion David Miller
2015-07-30 22:51 ` David Miller [this message]
2015-07-30 23:18 ` Florian Fainelli
2015-07-31 1:51 ` Florian Fainelli
2015-07-31 4:24 ` Chris Packham
2015-07-31 6:08 ` Eric Dumazet
2015-07-31 17:05 ` Florian Fainelli
2015-07-31 22:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730.155124.2216613161860898066.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=andrey.volkov@nexvision.fr \
--cc=cphealy@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=jerome.oufella@savoirfairelinux.com \
--cc=jonasj76@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mathieu@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).