Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

[Lee Jones <lee.jones@linaro.org>]

On Wed, 29 Jul 2015, Paul Bolle wrote:

> On ma, 2015-07-27 at 10:44 +0100, Lee Jones wrote:
> > --- /dev/null
> > +++ b/drivers/mailbox/mailbox-sti.c
> 
> > +static int sti_mbox_probe(struct platform_device *pdev)
> > +{
> > +	[...]
> > +
> > +	match = of_match_device(sti_mailbox_match, &pdev->dev);
> > +	if (!match) {
> > +		dev_err(&pdev->dev, "No configuration found\n");
> > +		return -ENODEV;
> > +	}
> > +	pdev->dev.platform_data = (struct sti_mbox_pdata *) match->data;
> > +
> > +	[...]
> > +}
> 
> > +static struct platform_driver sti_mbox_driver = {
> > +	.probe = sti_mbox_probe,
> > +	.remove = sti_mbox_remove,
> > +	.driver = {
> > +		.name = "sti-mailbox",
> > +		.of_match_table = sti_mailbox_match,
> > +	},
> > +};
> > +module_platform_driver(sti_mbox_driver);
> 
> > +MODULE_ALIAS("platform:mailbox-sti");
> 
> It seems this alias is only useful if there's a corresponding struct
> platform_device with a "mailbox-sti" .name. I couldn't spot that
> platform_device.
> 
> Besides, if I read sti_max_probe() correctly, without OF support loading
> this module won't accomplish much. So what would another way of
> autoloading this module buy you?

I think this line can be safely removed.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog