From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752439AbbG3Nb2 (ORCPT ); Thu, 30 Jul 2015 09:31:28 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:35407 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751191AbbG3NbZ (ORCPT ); Thu, 30 Jul 2015 09:31:25 -0400 Date: Thu, 30 Jul 2015 14:31:20 +0100 From: Lee Jones To: Paul Bolle Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, jassisinghbrar@gmail.com, devicetree@vger.kernel.org Subject: Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP Message-ID: <20150730133120.GA3208@x1> References: <1437990272-23111-1-git-send-email-lee.jones@linaro.org> <1437990272-23111-4-git-send-email-lee.jones@linaro.org> <1438121215.30903.27.camel@tiscali.nl> <20150730114545.GG14642@x1> <1438260522.25464.12.camel@tiscali.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1438260522.25464.12.camel@tiscali.nl> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Jul 2015, Paul Bolle wrote: > On do, 2015-07-30 at 12:45 +0100, Lee Jones wrote: > > On Wed, 29 Jul 2015, Paul Bolle wrote: > > > Besides, if I read sti_max_probe() correctly, without OF support > > > loading > > > this module won't accomplish much. So what would another way of > > > autoloading this module buy you? > > > > I think this line can be safely removed. > > Looking at this patch a little more I notice there's no line reading > MODULE_DEVICE_TABLE(of, sti_mailbox_match); > > The three mailbox drivers that currently support OF do have such a line. > So "another way of autoloading" was rather sloppy as now I don't see how > this driver, if build as a module, will get auto-loaded. Maybe there's > an auto-loading mechanism that I'm not aware of here. Or perhaps auto > -loading is not needed. > > Similar question for patch 5/6 and the lack of a line reading > MODULE_DEVICE_TABLE(of, mbox_test_match); Yes, both of those lines should be present. FYW, I don't test these drivers as modules and have no desire to. I always build everything into a single kernel binary, so any feedback regarding the module enabling code is appreciated. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog