From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946084AbbHGSkK (ORCPT ); Fri, 7 Aug 2015 14:40:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40748 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1945911AbbHGSkI (ORCPT ); Fri, 7 Aug 2015 14:40:08 -0400 Date: Fri, 7 Aug 2015 11:40:07 -0700 From: Greg KH To: Tal Shorer Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v3] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification Message-ID: <20150807184007.GA11658@kroah.com> References: <20150807180711.GB11113@kroah.com> <1438971360-22156-1-git-send-email-tal.shorer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438971360-22156-1-git-send-email-tal.shorer@gmail.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 07, 2015 at 09:16:00PM +0300, Tal Shorer wrote: > >From the usb 3.1 spec available at http://www.usb.org/developers/docs/ > table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and > GetPortErrorCount as: > > Request bmRequestType bRequest wValue wIndex wLength Data > SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None > GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link Errors on this port Still does not look correct to me, how about you?