From: Liviu Dudau <Liviu.Dudau@arm.com>
To: Punit Agrawal <punit.agrawal@arm.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <Mark.Rutland@arm.com>,
Sudeep Holla <Sudeep.Holla@arm.com>
Subject: Re: [PATCH v2 10/10] arm64: dts: Create SoC thermal zone for Juno
Date: Wed, 12 Aug 2015 16:55:00 +0100 [thread overview]
Message-ID: <20150812155500.GW20890@e106497-lin.cambridge.arm.com> (raw)
In-Reply-To: <1438615378-14241-11-git-send-email-punit.agrawal@arm.com>
On Mon, Aug 03, 2015 at 04:22:58PM +0100, Punit Agrawal wrote:
> Setup a thermal zone driven by the SoC temperature sensor on Juno
> r0. Create passive trip points and bind them to cpufreq cooling
> devices that support the power extensions.
Hi Punit,
>
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> ---
> arch/arm64/boot/dts/arm/juno.dts | 50 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts
> index d2e67f3..664961c 100644
> --- a/arch/arm64/boot/dts/arm/juno.dts
> +++ b/arch/arm64/boot/dts/arm/juno.dts
> @@ -9,6 +9,7 @@
> /dts-v1/;
>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/thermal/thermal.h>
>
> / {
> model = "ARM Juno development board (r0)";
> @@ -90,6 +91,8 @@
> next-level-cache = <&A57_L2>;
> clocks = <&scpi_dvfs 0>;
> cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> + #cooling-cells = <2>;
> + dynamic-power-coefficient = <530>;
The Documentation/devicetree/bindings/thermal/thermal.txt document describes two additional
required properties, cooling-min-state and cooling-max-state which are missing here.
> };
>
> A57_1: cpu@1 {
> @@ -100,6 +103,8 @@
> next-level-cache = <&A57_L2>;
> clocks = <&scpi_dvfs 0>;
> cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> + #cooling-cells = <2>;
> + dynamic-power-coefficient = <530>;
> };
>
> A53_0: cpu@100 {
> @@ -110,6 +115,8 @@
> next-level-cache = <&A53_L2>;
> clocks = <&scpi_dvfs 1>;
> cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> + #cooling-cells = <2>;
> + dynamic-power-coefficient = <140>;
> };
>
> A53_1: cpu@101 {
> @@ -120,6 +127,8 @@
> next-level-cache = <&A53_L2>;
> clocks = <&scpi_dvfs 1>;
> cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> + #cooling-cells = <2>;
> + dynamic-power-coefficient = <140>;
> };
>
> A53_2: cpu@102 {
> @@ -130,6 +139,8 @@
> next-level-cache = <&A53_L2>;
> clocks = <&scpi_dvfs 1>;
> cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> + #cooling-cells = <2>;
> + dynamic-power-coefficient = <140>;
> };
>
> A53_3: cpu@103 {
> @@ -140,6 +151,8 @@
> next-level-cache = <&A53_L2>;
> clocks = <&scpi_dvfs 1>;
> cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
> + #cooling-cells = <2>;
> + dynamic-power-coefficient = <140>;
> };
>
> A57_L2: l2-cache0 {
> @@ -167,5 +180,42 @@
> <&A53_3>;
> };
>
> + thermal-zones {
> + soc_thermal {
> + polling-delay = <1000>;
> + polling-delay-passive = <100>;
> + sustainable-power = <2500>;
> +
> + thermal-sensors = <&scpi_sensors0 3>;
> +
> + trips {
> + threshold: trip-point@0 {
You also need a reg= property if you have the @index thing.
Best regards,
Liviu
> + temperature = <55000>;
> + hysteresis = <1000>;
> + type = "passive";
> + };
> + target: trip-point@1 {
> + temperature = <65000>;
> + hysteresis = <1000>;
> + type = "passive";
> + };
> + };
> +
> + cooling-maps {
> + map0 {
> + trip = <&target>;
> + cooling-device = <&A53_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + contribution = <2048>;
> + };
> + map1 {
> + trip = <&target>;
> + cooling-device = <&A57_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + contribution = <1024>;
> + };
> +
> + };
> + };
> + };
> +
> #include "juno-base.dtsi"
> };
> --
> 2.1.4
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
next prev parent reply other threads:[~2015-08-12 15:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 15:22 [PATCH v2 00/10] Platform support for thermal management on Juno Punit Agrawal
2015-08-03 15:22 ` [PATCH v2 01/10] devicetree: bindings: Add optional dynamic-power-coefficient property Punit Agrawal
2015-08-03 15:22 ` [PATCH v2 02/10] cpufreq-dt: Supply power coefficient when registering cooling devices Punit Agrawal
2015-08-03 15:22 ` [PATCH v2 03/10] cpufreq: arm_big_little: Add support to register a cpufreq cooling device Punit Agrawal
2015-08-03 15:22 ` [PATCH v2 04/10] thermal: Fix thermal_zone_of_sensor_register to match documentation Punit Agrawal
2015-08-03 15:56 ` Guenter Roeck
2015-08-04 11:00 ` Punit Agrawal
2015-08-05 9:57 ` [PATCH v3] " Punit Agrawal
2015-08-05 14:51 ` Guenter Roeck
2015-08-03 15:22 ` [PATCH v2 05/10] Documentation: add DT bindings for ARM SCPI sensors Punit Agrawal
2015-09-03 15:08 ` Punit Agrawal
2015-08-03 15:22 ` [PATCH v2 06/10] firmware: arm_scpi: Extend to support sensors Punit Agrawal
2015-08-03 15:22 ` [PATCH v2 07/10] hwmon: Support sensors exported via ARM SCP interface Punit Agrawal
2015-08-04 21:32 ` Guenter Roeck
2015-08-05 10:17 ` Punit Agrawal
2015-08-03 15:22 ` [PATCH v2 08/10] hwmon: Support registration of thermal zones for SCP temperature sensors Punit Agrawal
2015-08-04 21:39 ` Guenter Roeck
2015-08-05 10:17 ` Punit Agrawal
2015-08-03 15:22 ` [PATCH v2 09/10] arm64: dts: Add sensor node to Juno dt Punit Agrawal
2015-08-03 15:22 ` [PATCH v2 10/10] arm64: dts: Create SoC thermal zone for Juno Punit Agrawal
2015-08-12 15:55 ` Liviu Dudau [this message]
2015-08-13 14:28 ` Punit Agrawal
2015-08-14 12:38 ` Punit Agrawal
2015-08-14 12:44 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150812155500.GW20890@e106497-lin.cambridge.arm.com \
--to=liviu.dudau@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Sudeep.Holla@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=punit.agrawal@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).