From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752968AbbHNE4T (ORCPT ); Fri, 14 Aug 2015 00:56:19 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:41558 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752640AbbHNE4S (ORCPT ); Fri, 14 Aug 2015 00:56:18 -0400 Date: Thu, 13 Aug 2015 21:41:07 -0700 (PDT) Message-Id: <20150813.214107.830938216718961195.davem@davemloft.net> To: sasha.levin@oracle.com Cc: tom@herbertland.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: allow sleeping when modifying store_rps_map From: David Miller In-Reply-To: <1439488996-31227-1-git-send-email-sasha.levin@oracle.com> References: <1439488996-31227-1-git-send-email-sasha.levin@oracle.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 13 Aug 2015 21:41:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sasha Levin Date: Thu, 13 Aug 2015 14:03:16 -0400 > Commit 10e4ea751 ("net: Fix race condition in store_rps_map") has moved the > manipulation of the rps_needed jump label under a spinlock. Since changing > the state of a jump label may sleep this is incorrect and causes warnings > during runtime. > > Make rps_map_lock a mutex to allow sleeping under it. > > Fixes: 10e4ea751 ("net: Fix race condition in store_rps_map") > Signed-off-by: Sasha Levin Applied, thanks.