From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Chris J Arges <chris.j.arges@canonical.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Michal Marek <mmarek@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>, Pedro Alves <palves@redhat.com>,
Namhyung Kim <namhyung@gmail.com>,
Bernd Petrovitsch <bernd@petrovitsch.priv.at>,
x86@kernel.org, live-patching@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 00/21] Compile-time stack validation
Date: Wed, 12 Aug 2015 21:07:00 -0500 [thread overview]
Message-ID: <20150813020700.GC25439@treble.redhat.com> (raw)
In-Reply-To: <55CBB9A1.7000800@canonical.com>
On Wed, Aug 12, 2015 at 04:24:49PM -0500, Chris J Arges wrote:
> <snip>
> >
> > Thanks for trying it out. I couldn't figure out how to recreate this
> > exact error, but I played around with "make mrproper" and saw some
> > probably related errors. Does this fix it?
> >
> > ---8<---
> >
> > Subject: [PATCH] stackvalidate: fix circular build dependencies
> >
> > After "make mrproper" with CONFIG_STACK_VALIDATION enabled, I get the
> > following errors:
> >
> > make[2]: *** No rule to make target 'arch/x86/purgatory/purgatory.o', needed by 'arch/x86/purgatory/purgatory.ro'. Stop.
> > make[3]: *** No rule to make target 'scripts/mod/empty.o', needed by 'scripts/mod/elfconfig.h'. Stop.
> >
> > These are caused by circular dependencies. The %.o pattern rules in
> > scripts/Makefile.build have the stackvalidate binary listed as a
> > dependency. But stackvalidate gets built *after* archprepare and
> > scripts/mod, both of which build objects using the %.o pattern rules.
> >
> > The STACKVALIDATE and STACKVALIDATE_foo.o variables are already used to
> > determine whether to validate a given object. Also use them to
> > determine whether to create the pattern rule dependency.
> >
> > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> > ---
> > scripts/Makefile.build | 7 +++++--
> > scripts/mod/Makefile | 2 ++
> > 2 files changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> > index a1270d3..ec96c51 100644
> > --- a/scripts/Makefile.build
> > +++ b/scripts/Makefile.build
> > @@ -243,7 +243,7 @@ endif
> >
> > ifdef CONFIG_STACK_VALIDATION
> >
> > -stackvalidate = $(objtree)/scripts/stackvalidate/stackvalidate
> > +__stackvalidate = $(objtree)/scripts/stackvalidate/stackvalidate
> >
> > ifndef CONFIG_FRAME_POINTER
> > nofp = --no-frame-pointer
> > @@ -251,9 +251,12 @@ endif
> >
> > # Set STACKVALIDATE_foo.o=n to skip stack validation for a file.
> > # Set STACKVALIDATE=n to skip stack validation for a directory.
> > +stackvalidate = $(if $(patsubst n%,, \
> > + $(STACKVALIDATE_$(basetarget).o)$(STACKVALIDATE)y), \
> > + $(__stackvalidate))
> > cmd_stackvalidate = $(if $(patsubst n%,, \
> > $(STACKVALIDATE_$(basetarget).o)$(STACKVALIDATE)y), \
> > - $(stackvalidate) $(nofp) "$(@)";)
> > + $(__stackvalidate) $(nofp) "$(@)";)
> >
> > endif # CONFIG_STACK_VALIDATION
> >
> > diff --git a/scripts/mod/Makefile b/scripts/mod/Makefile
> > index c11212f..374c413 100644
> > --- a/scripts/mod/Makefile
> > +++ b/scripts/mod/Makefile
> > @@ -1,3 +1,5 @@
> > +STACKVALIDATE := n
> > +
> > hostprogs-y := modpost mk_elfconfig
> > always := $(hostprogs-y) empty.o
> >
> >
>
> Josh,
>
> I still get build failures and I've pared it down to x86_64 defconfig plus:
> CONFIG_MODVERSIONS=y
> CONFIG_STACK_VALIDATION=y
Are you still seeing the same error as before? I think the errors you
saw were caused by stackvalidate choking on scripts/mod/empty.o. But I
don't see how that's still possible with the above patch since I set
STACKVALIDATE to 'n' in scripts/mod/Makefile which should tell it to
skip the directory.
> And it seems like some modules may get the .tmp_foo.o treatment while
> others end up foo.o so something like the following will not work:
>
> cmd_stackvalidate = $(if $(patsubst n%,, \
> $(STACKVALIDATE_$(basetarget).o)$(STACKVALIDATE)y), \
> $(__stackvalidate) $(nofp) "$(@D)/.tmp_$(@F)";)
>
> In addition, I'm not sure if skipping modules like STACKVALIDATE_foo.o=n
> will still function properly for modversioned modules.
I'm not sure that's really a problem, since I don't think we'll need to
skip validation of any module code. It's only used for skipping code
which runs outside of the kernel's normal operation (e.g., boot, vdso,
kexec).
--
Josh
next prev parent reply other threads:[~2015-08-13 2:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 21:31 [PATCH v8 00/21] Compile-time stack validation Chris J Arges
2015-08-12 4:43 ` Josh Poimboeuf
2015-08-12 21:24 ` Chris J Arges
2015-08-13 2:07 ` Josh Poimboeuf [this message]
2015-08-13 11:22 ` Josh Poimboeuf
2015-08-13 14:42 ` Chris J Arges
2015-08-13 14:50 ` Josh Poimboeuf
-- strict thread matches above, loose matches on Subject: below --
2015-07-28 14:46 Josh Poimboeuf
2015-08-06 8:07 ` Ingo Molnar
2015-08-06 16:06 ` Josh Poimboeuf
2015-08-06 17:23 ` Josh Poimboeuf
2015-08-06 17:46 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813020700.GC25439@treble.redhat.com \
--to=jpoimboe@redhat.com \
--cc=andi@firstfloor.org \
--cc=bernd@petrovitsch.priv.at \
--cc=bp@alien8.de \
--cc=chris.j.arges@canonical.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=namhyung@gmail.com \
--cc=palves@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).