From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752672AbbHMNkD (ORCPT <rfc822;w@1wt.eu>);
	Thu, 13 Aug 2015 09:40:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52259 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751862AbbHMNkB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 13 Aug 2015 09:40:01 -0400
Date: Thu, 13 Aug 2015 15:37:45 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Dave Chinner <david@fromorbit.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Peter Zijlstra <peterz@infradead.org>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/8] introduce __sb_{acquire,release}_write() helpers
Message-ID: <20150813133744.GA16888@redhat.com>
References: <20150811170343.GA26881@redhat.com> <20150811170358.GA26901@redhat.com> <20150813094552.GC26599@quack.suse.cz> <20150813095617.GD26599@quack.suse.cz> <20150813131744.GA15609@redhat.com> <20150813133246.GB1091@quack.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150813133246.GB1091@quack.suse.cz>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/13, Jan Kara wrote:
>
> On Thu 13-08-15 15:17:44, Oleg Nesterov wrote:
> >
> > so I agree with any naming, I'll update this patch... but perhaps
> > __sb_writers_acquire() without "_nowait" make more sense?
>
> OK, drop _nowait - maybe:
>
> __sb_writers_acquired()
>
> (note the additional 'd' at the end) to suggest that we already hold the lock
> and only want to tell lockdep about it?

Agreed! Will do in v3.

Oleg.