From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753232AbbHMQN6 (ORCPT ); Thu, 13 Aug 2015 12:13:58 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:59129 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752083AbbHMQN4 (ORCPT ); Thu, 13 Aug 2015 12:13:56 -0400 Date: Thu, 13 Aug 2015 18:06:26 +0200 From: Andrew Lunn To: Philip Downey Cc: David Miller , "kuznet@ms2.inr.ac.ru" , "jmorris@namei.org" , "yoshfuji@linux-ipv6.org" , "kaber@trash.net" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH] IGMP: Inhibit reports for local multicast groups Message-ID: <20150813160626.GF32484@lunn.ch> References: <1439396033-6264-1-git-send-email-pdowney@brocade.com> <20150812.164519.1783786478654950784.davem@davemloft.net> <57f72e6a6f024628bd18ef4b139ac31e@EMEAWP-EXMB12.corp.brocade.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57f72e6a6f024628bd18ef4b139ac31e@EMEAWP-EXMB12.corp.brocade.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 13, 2015 at 02:48:23PM +0000, Philip Downey wrote: > Hi David > Thanks for taking the time to review and comment. > This is my first upstream request so please forgive any ignorance on my part. I have added a new proposed commit wording below with a view to agreeing the content before resubmitting the patch. > I hope it is sufficient to address your concerns. > > IGMP: Inhibit reports for local multicast groups > > The range of addresses between 224.0.0.0 and 224.0.0.255 > inclusive, is reserved for the use of routing protocols and other > low-level topology discovery or maintenance protocols, such as > gateway discovery and group membership reporting. Multicast > routers should not forward any multicast datagram with destination > addresses in this range, regardless of its TTL. > > Currently, IGMP reports are generated for this reserved range of > addresses even though a router will ignore this information since > it has no purpose. Hi Philip What about switches which are doing IGMP snooping? Andrew