From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH v2] Input: drivers/joystick: use parallel port device model
Date: Thu, 13 Aug 2015 09:26:02 -0700 [thread overview]
Message-ID: <20150813162602.GA15693@dtor-ws> (raw)
In-Reply-To: <20150813134614.GA29298@sudip-pc>
On Thu, Aug 13, 2015 at 07:16:14PM +0530, Sudip Mukherjee wrote:
> On Sat, Aug 08, 2015 at 04:05:15PM +0530, Sudip Mukherjee wrote:
> > On Tue, Aug 04, 2015 at 07:55:51PM +0530, Sudip Mukherjee wrote:
> > > Modify db9 driver to use the new Parallel Port device model.
> > >
> > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > > ---
> > >
> > > v2: an extra check was removed. db9_base could not be removed. Already
> > > mailed you the reasons, reference is at:
> > > https://lkml.org/lkml/2015/8/3/403
> >
> > Hi Dmitry,
> > I was telling you on the other thread that to remove db9_base we will
> > need to modify the parport code and then it has to be tested by everyone
> > again and that will also change the old behaviour of parport. The v2 to
> > which I am replying now is still having that db9_base.
> >
> > Please see the following patch, this is the minimum change required to
> > update db9 driver. Personally I donot like this approach as in this
> > method if a parallel port is hotplugged after this driver is loaded then
> > it will not work. Please let me know your views on the posted v2 and
> > also on the following proposal.
>
> Hi Dmitry,
> Did you have a chance to look at this?
Right, so I agree that we should allow for hotplug and so the v2 is in
that sense is better than v3.
I still would prefer for the core to keep track of relationship between
devices and drivers, but if you would prefer to postpone implementing it
that woudl be fine.
> Pali Rohár has the hardware and he is ready to test it.
Pali, could you give the v2 version of the patch a spin
(https://patchwork.kernel.org/patch/6940321/)?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-08-13 16:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 14:25 [PATCH v2] Input: drivers/joystick: use parallel port device model Sudip Mukherjee
2015-08-08 10:35 ` Sudip Mukherjee
2015-08-13 13:46 ` Sudip Mukherjee
2015-08-13 16:26 ` Dmitry Torokhov [this message]
2015-08-14 6:55 ` Sudip Mukherjee
2015-08-14 7:05 ` Pali Rohár
2015-08-17 7:29 ` Sudip Mukherjee
2015-08-31 13:44 ` Sudip Mukherjee
2015-08-31 13:55 ` Pali Rohár
2015-08-31 14:45 ` Sudip Mukherjee
2015-09-28 16:40 ` Pali Rohár
2015-09-28 23:23 ` Dmitry Torokhov
2015-09-29 7:10 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813162602.GA15693@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).