From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Brendan Gregg <brendan.d.gregg@gmail.com>
Subject: Re: [BUGFIX PATCH perf/core ] perf-probe: Fix to add missed brace around if block
Date: Thu, 13 Aug 2015 15:09:43 -0300 [thread overview]
Message-ID: <20150813180942.GF30356@kernel.org> (raw)
In-Reply-To: <20150812215541.9088.62425.stgit@localhost.localdomain>
Em Thu, Aug 13, 2015 at 06:55:41AM +0900, Masami Hiramatsu escreveu:
> The commit 75186a9b09e4 (perf probe: Fix to show lines of
> sys_ functions correctly) introduced a bug by a missed brace
> around if block. This fixes to add it.
>
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thanks! now it works:
[root@zoo ~]# perf probe 'get_timeval=sys_select:11 tv_sec=tv.tv_sec tv_usec=tv.tv_usec'
Added new event:
probe:get_timeval (on sys_select:11 with tv_sec=tv.tv_sec tv_usec=tv.tv_usec)
You can now use it in all perf tools, such as:
perf record -e probe:get_timeval -aR sleep 1
[root@zoo ~]# perf probe -l
probe:get_timeval (on SYSC_select:11@/home/git/linux/fs/select.c with tv_sec tv_usec)
probe:vfs_getname (on getname_flags:72@/home/git/linux/fs/namei.c with pathname)
[root@zoo ~]#
Now we have:
# strace -e select -p 960
Process 960 attached
select(13, [4 5 7 9 10 11 12], [], [5], {10, 0}) = 0 (Timeout)
select(13, [4 5 7 9 10 11 12], [], [5], {9, 999999}) = 0 (Timeout)
select(13, [4 5 7 9 10 11 12], [], [5], {10, 0}) = 0 (Timeout)
select(13, [4 5 7 9 10 11 12], [], [5], {10, 0}) = 0 (Timeout)
select(13, [4 5 7 9 10 11 12], [], [5], {0, 3072}) = 0 (Timeout)
At the same time as:
# trace --ev probe:get_timeval -e select -p 960
0.322 ( 0.013 ms): select(n: 13, inp: 0x55ac425996c0, outp: 0x55ac42599750, exp: 0x55ac425997e0, tvp: 0x7ffd3371fa30) ...
0.322 ( ): probe:get_timeval:(ffffffff81228f15) tv_sec=10 tv_usec=0)
10022.189 (10021.880 ms): ... [continued]: select()) = 0 Timeout
10022.681 ( 0.043 ms): select(n: 13, inp: 0x55ac425996c0, outp: 0x55ac42599750, exp: 0x55ac425997e0, tvp: 0x7ffd3371fa30) ...
10022.681 ( ): probe:get_timeval:(ffffffff81228f15) tv_sec=9 tv_usec=999999)
20040.673 (10018.035 ms): ... [continued]: select()) = 0 Timeout
20041.174 ( 0.046 ms): select(n: 13, inp: 0x55ac425996c0, outp: 0x55ac42599750, exp: 0x55ac425997e0, tvp: 0x7ffd3371fa30) ...
20041.174 ( ): probe:get_timeval:(ffffffff81228f15) tv_sec=10 tv_usec=0)
30063.041 (10021.912 ms): ... [continued]: select()) = 0 Timeout
30063.581 ( 0.042 ms): select(n: 13, inp: 0x55ac425996c0, outp: 0x55ac42599750, exp: 0x55ac425997e0, tvp: 0x7ffd3371fa30) ...
30063.581 ( ): probe:get_timeval:(ffffffff81228f15) tv_sec=10 tv_usec=0)
40085.448 (10021.909 ms): ... [continued]: select()) = 0 Timeout
40087.983 ( 0.033 ms): select(n: 13, inp: 0x55ac425996c0, outp: 0x55ac42599750, exp: 0x55ac425997e0, tvp: 0x7ffd3371fa30) ...
40087.983 ( ): probe:get_timeval:(ffffffff81228f15) tv_sec=0 tv_usec=3072)
40091.202 ( 3.252 ms): ... [continued]: select()) = 0 Timeout
Seems to be working, now its just to add support in 'perf trace' for a
"get_timeval" wannabe tracepoint in the same fashion as there is support for
another wannabe tracepoint: "vfs_getname", add more of these where timevals are
copied from the kernel, etc.
Anyway, now 'perf probe' suits my needs with syscalls, applied!
Thanks,
- Arnaldo
next prev parent reply other threads:[~2015-08-13 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 21:55 [BUGFIX PATCH perf/core ] perf-probe: Fix to add missed brace around if block Masami Hiramatsu
2015-08-13 18:09 ` Arnaldo Carvalho de Melo [this message]
2015-08-20 9:55 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813180942.GF30356@kernel.org \
--to=acme@kernel.org \
--cc=brendan.d.gregg@gmail.com \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).