From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752339AbbHOH1B (ORCPT ); Sat, 15 Aug 2015 03:27:01 -0400 Received: from mail-la0-f45.google.com ([209.85.215.45]:33502 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbbHOH07 (ORCPT ); Sat, 15 Aug 2015 03:26:59 -0400 Date: Sat, 15 Aug 2015 13:26:36 +0600 From: Alexander Kuleshov To: Andrew Morton Cc: Tony Luck , Pekka Enberg , Mel Gorman , Baoquan He , Tang Chen , Robin Holt , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memblock: validate the creation of debugfs files Message-ID: <20150815072636.GA2539@localhost> References: <1439579011-14918-1-git-send-email-kuleshovmail@gmail.com> <20150814141944.4172fee6c9d7ae02a6258c80@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150814141944.4172fee6c9d7ae02a6258c80@linux-foundation.org> X-Operating-System: Linux X-Date: Sat Aug 15 13:19:45 ALMT 2015 User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andrew, On 08-14-15, Andrew Morton wrote: > On Sat, 15 Aug 2015 01:03:31 +0600 Alexander Kuleshov wrote: > > > Signed-off-by: Alexander Kuleshov > > There's no changelog. Yes, will add it if there will be sense in the patch. > > Why? Ignoring the debugfs API return values is standard practice. > Yes, but I saw many places where this practice is applicable (for example in the kernel/kprobes and etc.), besides this, the memblock API is used mostly at early stage, so we will have some output if something going wrong.