From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754654AbbHOTwp (ORCPT ); Sat, 15 Aug 2015 15:52:45 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:48996 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752442AbbHOTv2 (ORCPT ); Sat, 15 Aug 2015 15:51:28 -0400 Date: Sat, 15 Aug 2015 14:46:38 +0200 From: Peter Zijlstra To: Morten Rasmussen Cc: mingo@redhat.com, vincent.guittot@linaro.org, daniel.lezcano@linaro.org, Dietmar Eggemann , yuyang.du@intel.com, mturquette@baylibre.com, rjw@rjwysocki.net, Juri Lelli , sgurrappadi@nvidia.com, pang.xunlei@zte.com.cn, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [RFCv5 PATCH 40/46] sched/cpufreq_sched: compute freq_new based on capacity_orig_of() Message-ID: <20150815124638.GG10304@worktop.programming.kicks-ass.net> References: <1436293469-25707-1-git-send-email-morten.rasmussen@arm.com> <1436293469-25707-41-git-send-email-morten.rasmussen@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436293469-25707-41-git-send-email-morten.rasmussen@arm.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 07, 2015 at 07:24:23PM +0100, Morten Rasmussen wrote: > diff --git a/kernel/sched/cpufreq_sched.c b/kernel/sched/cpufreq_sched.c > index 2968f3a..7071528 100644 > --- a/kernel/sched/cpufreq_sched.c > +++ b/kernel/sched/cpufreq_sched.c > @@ -184,7 +184,7 @@ void cpufreq_sched_set_cap(int cpu, unsigned long capacity) > goto out; > > /* Convert the new maximum capacity request into a cpu frequency */ > - freq_new = capacity * policy->max >> SCHED_CAPACITY_SHIFT; > + freq_new = (capacity * policy->max) / capacity_orig_of(cpu); > > /* No change in frequency? Bail and return current capacity. */ > if (freq_new == policy->cur) Can't we avoid exporting that lot by simply passing in the right values to begin with?