From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751962AbbHRFY0 (ORCPT ); Tue, 18 Aug 2015 01:24:26 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:32812 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089AbbHRFYZ (ORCPT ); Tue, 18 Aug 2015 01:24:25 -0400 Date: Tue, 18 Aug 2015 10:54:17 +0530 From: Sudip Mukherjee To: =?iso-8859-1?Q?Rapha=EBl?= Beamonte Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Greg Donald , Cristina Opriceana Subject: Re: [PATCH 07/20] staging: rtl8192u: r8192_core: whitespace neatening Message-ID: <20150818052417.GD2941@sudip-pc> References: <717595814bcdd3a5f95a9d046183cac41d44d791.1439688440.git.raphael.beamonte@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <717595814bcdd3a5f95a9d046183cac41d44d791.1439688440.git.raphael.beamonte@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 15, 2015 at 09:34:03PM -0400, Raphaël Beamonte wrote: > Signed-off-by: Raphaël Beamonte > --- > @@ -2182,30 +2182,30 @@ static void rtl8192_init_priv_variable(struct net_device *dev) > priv->EarlyRxThreshold = 7; > priv->enable_gpio0 = 0; > priv->TransmitConfig = > - (TCR_MXDMA_2048< - (priv->ShortRetryLimit< - (priv->LongRetryLimit< + (TCR_MXDMA_2048 << TCR_MXDMA_OFFSET) | // Max DMA Burst Size per Tx DMA Burst, 7: reserved. > + (priv->ShortRetryLimit << TCR_SRL_OFFSET) | // Short retry limit > + (priv->LongRetryLimit << TCR_LRL_OFFSET) | // Long retry limit > (false ? TCR_SAT : 0); // FALSE: HW provides PLCP length and LENGEXT, TRUE: SW provides them > #ifdef TO_DO_LIST > if (Adapter->bInHctTest) > pHalData->ReceiveConfig = pHalData->CSMethod | > - RCR_AMF | RCR_ADF | //accept management/data > + RCR_AMF | RCR_ADF | //accept management/data > //guangan200710 > - RCR_ACF | //accept control frame for SW AP needs PS-poll, 2005.07.07, by rcnjko. > - RCR_AB | RCR_AM | RCR_APM | //accept BC/MC/UC > - RCR_AICV | RCR_ACRC32 | //accept ICV/CRC error packet > - ((u32)7< - (pHalData->EarlyRxThreshold< + RCR_ACF | //accept control frame for SW AP needs PS-poll, 2005.07.07, by rcnjko. > + RCR_AB | RCR_AM | RCR_APM | //accept BC/MC/UC > + RCR_AICV | RCR_ACRC32 | //accept ICV/CRC error packet > + ((u32)7 << RCR_MXDMA_OFFSET) | // Max DMA Burst Size per Tx DMA Burst, 7: reserved. looks like the comment has changed. copy paste error from previous lines? regards sudip