From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932120AbbHTOsn (ORCPT <rfc822;w@1wt.eu>);
	Thu, 20 Aug 2015 10:48:43 -0400
Received: from down.free-electrons.com ([37.187.137.238]:41629 "EHLO
	mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1753091AbbHTOsi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 20 Aug 2015 10:48:38 -0400
Date: Thu, 20 Aug 2015 16:48:36 +0200
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Michal Suchanek <hramrach@gmail.com>
Cc: linux-sunxi@googlegroups.com, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>, Mark Brown <broonie@kernel.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero
Message-ID: <20150820144836.GV30520@lukather>
References: <cover.1440080122.git.hramrach@gmail.com>
 <3688fab67e7cdc7bcbff73dfd6b0fcdcc4e79eb6.1440080122.git.hramrach@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="YnIutncTLXsDZs5t"
Content-Disposition: inline
In-Reply-To: <3688fab67e7cdc7bcbff73dfd6b0fcdcc4e79eb6.1440080122.git.hramrach@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--YnIutncTLXsDZs5t
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 20, 2015 at 02:19:46PM -0000, Michal Suchanek wrote:
> When the maximum transfer speed is not set for a SPI slave the value
> remains 0 and the code in sunxi SPI divides by it. Use an arbitrary
> speed instead in that case.
>=20
> Signed-off-by: Michal Suchanek <hramrach@gmail.com>

spi->max_speed_hz is set using the spi-max-frequency property, and
spi->will error out if that property isn't set. What am I missing?

Maxime

--=20
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

--YnIutncTLXsDZs5t
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJV1ejEAAoJEBx+YmzsjxAgrzoP/3TEQFw0jjKi4me7tQ7h+eRd
pHazq0mAnd8FdZM+0pCNIAXfJ40IUUpR1KkAJE+CbyafGF+AxY1DivH3EY+X+dBs
4rPDxA7ooOUUnyinJLcjXY79oM9AEQmxiJ6P8kRR9UL3T0Xz8p+2LpQMvUqqumPq
V9PdeVsUJ3qpbL3uPdHiCs7uvlhnLYWcaDkkcFpSLguDKtGbGPNwUVm+h4IrIRHk
07D6f2894VZmvum7HfVnP8wqPv4Y0uHpgkUk+LONKU3pmrc5A4r3FL7Vl+kdV6oi
UpH5vzn5lTffL0dshFKdymubUfeZ1RqumgICpWhLmuGhwrmuCsrB4oipozDREr/H
wSUp6tpJZMrLGiWbQnprxlw3Eu9IxbkPoxnl3dzTt2L1qDQwwDbKKVZ1lyDolwRV
uNFlE7XSZkL7i19CeMClzWFSoW4HKRsKeVPUwuQJuwSTw5R45PwwJ07zNNOBZ1x3
Wx8GNFy8msdzG5RlNC89mFIq1IEHf21B8xP36uTMDbA7HZbmzzA8xDFrtsrNYHFq
0qUwKY6WHRZEugEFpF2elyJN1r1t9FEM9EHjveO+kBrSoV3AmXOqL+XsihY7j+7q
nYpkngrNfEl5FOsa173wYGArT9HkVYQKBeH3aRuyHKUe/dBqabE9Wgk/dTYIeI/W
X91/9EgSTH6zriwhwWGd
=xj4q
-----END PGP SIGNATURE-----

--YnIutncTLXsDZs5t--