From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752798AbbHTVSz (ORCPT ); Thu, 20 Aug 2015 17:18:55 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47679 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751823AbbHTVSx (ORCPT ); Thu, 20 Aug 2015 17:18:53 -0400 Date: Thu, 20 Aug 2015 23:18:50 +0200 From: Maxime Ripard To: Mark Brown Cc: Michal Suchanek , linux-sunxi@googlegroups.com, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: Re: [PATCH 1/9] spi: sunxi: fix transfer timeout Message-ID: <20150820211850.GI30520@lukather> References: <0e0b52774a48ddb71dc8095b66942451cd31ff7d.1440080122.git.hramrach@gmail.com> <20150820184132.GO12027@sirena.org.uk> <20150820193433.GH30520@lukather> <20150820210830.GS12027@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yBd94+RIx/Fx7UDH" Content-Disposition: inline In-Reply-To: <20150820210830.GS12027@sirena.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yBd94+RIx/Fx7UDH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 20, 2015 at 02:08:30PM -0700, Mark Brown wrote: > On Thu, Aug 20, 2015 at 09:34:33PM +0200, Maxime Ripard wrote: > > On Thu, Aug 20, 2015 at 11:41:32AM -0700, Mark Brown wrote: > > > On Thu, Aug 20, 2015 at 02:19:45PM -0000, Michal Suchanek wrote: >=20 > > > > drivers/spi/spi-sun4i.c | 10 +++++++++- > > > > drivers/spi/spi-sun6i.c | 10 +++++++++- >=20 > > > Are we *sure* we can't work on merging these drivers :( >=20 > > Those are two different IPs, that don't really share anything but > > their author... >=20 > I seem to be seeing a number of changes like this one which make > apparently very similar modifications to both. Perhaps there is more > core usage that should be happening instead? Yeah, because I wrote the two at the same time, and they share the same flaws. But that doesn't really mean that you can share anything at the driver level. And I'm not really sure that we can do much more at the framework level either, except maybe handling the timeout directly (but then the drivers would have to handle the recovering after a timeout too). Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --yBd94+RIx/Fx7UDH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV1kQ6AAoJEBx+YmzsjxAgGxgP/28ZzMBpmBdlGGPRqp1H1xqV p3Aqu3Q8yS/CHZoMdY/AdsnvBRs5uA+PtwKgEW0sW67kI9NPELdTjXUt6RKBOrzO 6hz1N/NQ9NalM7uuSW6f+mLre5F6ymJ/4VIwToZQs5mYMJBevvpJ2lK/7bxyKNoD Cjx9kUMC6ZzGO38QQ9JOQK9q6NWmE1eErPhTBSI2Dn1yInuMm67wf1P8FgORkb6t zQUJS8t2br+/24paBo/TUh6lDJpomDDaPb66gvYEjb7M5WnalhrfdsJgBeXouJDO O6NXs0P8RioJ1Mf/Hf6Dl2Ki6wVcRJn7/fIYivAHj+kEFQEUdG6y2SQk8cv+s5av 62c+NDmM7JeVCDJbKPtjLKf0ghdq8N6Kf/7NCtec+Psaiw5SWrMYI5hwqeUsheXP 7XZDZyUFBG7DPA4Z4leGGKwI9VapL2j5O6+KW9txFgHFRwjHwIpeFbwbtckRBL21 CgpfJ8tXum+SMmZ7F5cpppdn3en0qDBbhh2/Owp9A55jRU7LS3GT6TWjzKSndy6Z v4CjxrU0c6w/qQ9KuavKg02S4zYUAHeDWZE8WTsjV9JQX24kztWTCJOfdLlqENGm zMYpUVw8+rVTbaEi8/K1h0lHwTqraNiSR5ZG8GktSHD3mkAfkXYdFHXADlclMDix IFvAIsGapCsn48cwsBNv =gnUZ -----END PGP SIGNATURE----- --yBd94+RIx/Fx7UDH--