Re: [PATCH 0/4] firmware_class: few small code shifts

From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
	ming.lei@canonical.com, corbet@lwn.net,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	dwmw2@infradead.org, dhowells@redhat.com,
	seth.forshee@canonical.com, rusty@rustcorp.com.au,
	mmarek@suse.cz, mjg59@srcf.ucam.org, kyle@kernel.org,
	linux-security-module@vger.kernel.org, keyrings@linux-nfs.org
Subject: Re: [PATCH 0/4] firmware_class: few small code shifts
Date: Sat, 22 Aug 2015 23:18:38 +0200	[thread overview]
Message-ID: <20150822211838.GC8051@wotan.suse.de> (raw)
In-Reply-To: <20150822053824.GA5834@kroah.com>

On Fri, Aug 21, 2015 at 10:38:24PM -0700, Greg KH wrote:
> On Fri, Aug 21, 2015 at 11:23:03PM +0200, Luis R. Rodriguez wrote:
> > On Tue, Aug 04, 2015 at 03:00:00PM -0700, Luis R. Rodriguez wrote:
> > > From: "Luis R. Rodriguez" <mcgrof@suse.com>
> > > 
> > > Ming, Greg,
> > > 
> > > this patch set consists of a few small code shifts which would make
> > > it easier to add extensible firmware API code, and later firmware
> > > signing support. This patch set is being sent out separately as it
> > > does not contain any controversial changes. It should also help
> > > with readibility of the code.
> > > 
> > > I'll be Cc'ing linux-doc, linux-security-module, and keyring folks as the
> > > next patch sets would start slowly diving into the topic of firmware signing
> > > and extending documentation, and those patches will depend on this set.
> > > 
> > > There is a superfluous else branch on patch #3, its not needed because of
> > > the goto statement but we leave that in place to make patch #4 easier to
> > > read.
> > > 
> > > David Howells (2):
> > >   firmware: fold successful fw read early
> > >   firmware: generalize reading file contents as a helper
> > > 
> > > Luis R. Rodriguez (2):
> > >   firmware: generalize "firmware" as "system data" helpers
> > >   firmware: move completing fw into a helper
> > 
> > Ming, Greg,
> > 
> > Please let me know if there are any issues with this series.
> 
> It's too late for 4.3 at the moment, and my first impulse is you are
> just painting the bikeshed by changing some printk names, so I don't
> like that,

This series doesn't address the actual sysdata helper changes which make the
firmware API easly extensible, it just paves the path for it, so because of
that what you describe is correct but only in lack of sight of the other RFC
patch I posted [0].

[0] http://1438730036-22913-1-git-send-email-mcgrof@do-not-panic.com

> but I'll review it in full after 4.3-rc1 is out, can't do
> anything until then.

Sure.

 Luis