From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754302AbbHXMSx (ORCPT ); Mon, 24 Aug 2015 08:18:53 -0400 Received: from sauhun.de ([89.238.76.85]:54549 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753608AbbHXMSv (ORCPT ); Mon, 24 Aug 2015 08:18:51 -0400 Date: Mon, 24 Aug 2015 14:18:45 +0200 From: Wolfram Sang To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Gwendal Grignou , Doug Anderson , Bartlomiej Zolnierkiewicz , Dmitry Torokhov , Lee Jones , Geert Uytterhoeven , Olof Johansson , linux-i2c@vger.kernel.org Subject: Re: [PATCH 5/6] i2c: Replace I2C_CROS_EC_TUNNEL dependency Message-ID: <20150824121845.GC3608@katana> References: <1439983198-4696-1-git-send-email-javier@osg.samsung.com> <1439983198-4696-6-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jousvV0MzM2p6OtC" Content-Disposition: inline In-Reply-To: <1439983198-4696-6-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jousvV0MzM2p6OtC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 19, 2015 at 01:19:57PM +0200, Javier Martinez Canillas wrote: > The ChromeOS EC tunnel I2C bus driver depend on CROS_EC_PROTO but > MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends > on is bad practice as it may lead to circular Kconfig dependencies. >=20 > Since the platform device that is matched with the I2C bus driver > is registered by the ChromeOS EC mfd driver, I2C_CROS_EC_TUNNEL > really depends on MFD_CROS_EC. And because this config option > selects CROS_EC_PROTO, that dependency is met as well. So make the > driver to depend on MFD_CROS_EC instead of CROS_EC_PROTO. >=20 > Signed-off-by: Javier Martinez Canillas >=20 Applied to for-next, thanks! --jousvV0MzM2p6OtC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV2wulAAoJEBQN5MwUoCm2XVgP/AqQ/TcRZhyyTcxvl03HBpIW HvBIU+MlBo5JzzcvedpGI10Z8oy5bsRUs1dT0cDbEJLtbqji/xXdqclIp/0QPOI/ chhGFY8lHGAvNfiAuyh35nG27iS/OFmPLISsZNow6/8RdigJytPxmU6+bjqDtkf0 njQc/y4W2Y3srX9t5G4rjxKBEsAlZ6Td3U8hVmilQi6TcvKXRj8DQjiUj4wLM40D VZYTT/4dfYx8X2KKiIiX9d5NvsI14fzZn+HZXoa5UXGK3b+0iuAE1IFDcCD5F0K+ fJ+m4PnyGKSWvxNnQu7TOgXH2TWnOWAsDr3xsfwWBFxMFzjYWUOKMh9gH97dZMbD WeTNBWZWL+AK+hJgAXCvvMq99Aj268roT6Xtk34ZNodNBeqmF8Ai3nIRS2G73Be1 4sh/qVDuCYSIUZSRSKY2D4tk+AUkg0tJgg/4jtE18UdKXY+stNGf5/dnJkOA9QJS 26/vYI1TqNx6eKZdSEWB9Jz7g2ndPTyRgYY7zTEzSKrWr876PoRyABHgvROTtWQQ zZMtHTBdPheZvh0HbBBxQ3dTe5yOLbfRjvXHEv3Dbvu5UijhlYMQMGYQPXI7e7LD E0zwPc6wncVzvG0cOx8AW4zBeBF1Goaro2vOkBwnXwiVil/rk6lcoEiVS/FXj+e2 FuvY/vTKTXDzVGr+rqcI =8bNo -----END PGP SIGNATURE----- --jousvV0MzM2p6OtC--