From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756198AbbHYVUK (ORCPT ); Tue, 25 Aug 2015 17:20:10 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:59739 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbbHYVUH (ORCPT ); Tue, 25 Aug 2015 17:20:07 -0400 Date: Tue, 25 Aug 2015 14:20:05 -0700 (PDT) Message-Id: <20150825.142005.1823541352876560634.davem@davemloft.net> To: pdowney@brocade.com Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] IGMP: Inhibit reports for local multicast groups From: David Miller In-Reply-To: <1c262ff7179d56eefb2c723538d1daaa88892730.1440415003.git.pdowney@brocade.com> References: <1> <1c262ff7179d56eefb2c723538d1daaa88892730.1440415003.git.pdowney@brocade.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 25 Aug 2015 14:20:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Philip Downey Date: Mon, 24 Aug 2015 12:39:17 +0100 > +extern int sysctl_igmp_link_local_reports; ... > +/* IGMP reports for link-local multicast groups are enabled by default */ > +#define IGMP_ENABLE_LLM 1 > + > +int sysctl_igmp_link_local_reports __read_mostly = IGMP_ENABLE_LLM; > + > +#define IGMP_INHIBIT_LINK_LOCAL_REPORTS(_ipaddr) \ > + (ipv4_is_local_multicast(_ipaddr) && \ > + (sysctl_igmp_link_local_reports == 0)) > + People know that "1" and "0" means enable and disable respectively, so this macros is pretty excessive. Just remove it. Also, simplify the name of the sysctl to something like "sysctl_igmp_llm_reports" or similar, and simplify the test against 0 to be in the canonical "!x" format. Then the test can fit on one line: (ipv4_is_local_multicast(_ipaddr) && !sysctl_igmp_llm_reports)