From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752307AbbH0EHJ (ORCPT <rfc822;w@1wt.eu>);
	Thu, 27 Aug 2015 00:07:09 -0400
Received: from smtp.nue.novell.com ([195.135.221.5]:57173 "EHLO
	smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752033AbbH0EHG (ORCPT
	<rfc822;groupwise-linux-kernel@vger.kernel.org:0:0>);
	Thu, 27 Aug 2015 00:07:06 -0400
Date: Thu, 27 Aug 2015 12:06:37 +0800
From: joeyli <jlee@suse.com>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>, linux-kernel@vger.kernel.org,
        linux-efi@vger.kernel.org, linux-pm@vger.kernel.org,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Matthew Garrett <matthew.garrett@nebula.com>,
        Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
        Josh Boyer <jwboyer@redhat.com>, Vojtech Pavlik <vojtech@suse.cz>,
        Matt Fleming <matt.fleming@intel.com>, Jiri Kosina <jkosina@suse.cz>,
        "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v2 04/16] x86/efi: Generating random number in EFI stub
Message-ID: <20150827040637.GA24088@linux-rxt1.site>
References: <1439273796-25359-1-git-send-email-jlee@suse.com>
 <1439273796-25359-5-git-send-email-jlee@suse.com>
 <20150820141221.GC2567@codeblueprint.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150820141221.GC2567@codeblueprint.co.uk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Matt, 

Thanks for your reviewing and sorry for my delay.

On Thu, Aug 20, 2015 at 03:12:21PM +0100, Matt Fleming wrote:
> On Tue, 11 Aug, at 02:16:24PM, Lee, Chun-Yi wrote:
> > This patch adds the codes for generating random number array as the
> > HMAC key that will used by later EFI stub codes.
> > 
> > The original codes in efi_random copied from aslr and add the codes
> > to accept input entropy and EFI debugging. In later patch will add
> > the codes to get random number by EFI protocol. The separate codes
> > can avoid impacting aslr function.
>  
> Is there some way we can share the code between aslr and the EFI boot
> stub? People may not review both files when making changes and so bug
> fixes to one might not appear in the other.
> 
> -- 
> Matt Fleming, Intel Open Source Technology Center

The origin design is base on get_random_long() from aslr, so I direct
copy it to efi_random.c then modified it. 
There have some reasons I didn't share the code with aslr:

 - There have some debug_puttstr() for debugging in aslr, but those
   debugging log do not work in EFI stub, and I want put efi_print
   for debugging purpose. I don't want affect the code in aslr, so
   I choice copy get_random_long() to efi_random.c specific for EFI stub.

 - In subsequent patches add EFI random protocol support to
   get_random_longh().

In next version, I will try to extract shared code to misc.c to reuse them
between aslr and efi_random.


Thanks a lot!
Joey Lee