From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753380AbbH3Kmg (ORCPT ); Sun, 30 Aug 2015 06:42:36 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:55282 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbbH3Kme (ORCPT ); Sun, 30 Aug 2015 06:42:34 -0400 Date: Sun, 30 Aug 2015 13:42:30 +0300 From: Mikko Rapeli To: Emil Velikov Cc: "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , linux-api@vger.kernel.org Subject: Re: [PATCH 03/98] drm.h: use __kernel_size_t instead of size_t Message-ID: <20150830104229.GW9187@lakka.kapsi.fi> References: <1433000370-19509-1-git-send-email-mikko.rapeli@iki.fi> <1433000370-19509-4-git-send-email-mikko.rapeli@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SA-Exim-Connect-IP: 2001:1bc8:1004::1 X-SA-Exim-Mail-From: mikko.rapeli@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 03, 2015 at 06:19:48PM +0100, Emil Velikov wrote: > On 30 May 2015 at 16:37, Mikko Rapeli wrote: > > Fixes userspace compilation error: > > > > drm/drm.h:132:2: error: unknown type name ‘size_t’ > > > > Signed-off-by: Mikko Rapeli > > --- > > include/uapi/drm/drm.h | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h > > index ff6ef62..b197650 100644 > > --- a/include/uapi/drm/drm.h > > +++ b/include/uapi/drm/drm.h > > @@ -129,11 +129,11 @@ struct drm_version { > > int version_major; /**< Major version */ > > int version_minor; /**< Minor version */ > > int version_patchlevel; /**< Patch level */ > > - size_t name_len; /**< Length of name buffer */ > > + __kernel_size_t name_len; /**< Length of name buffer */ > > char __user *name; /**< Name of driver */ > > - size_t date_len; /**< Length of date buffer */ > > + __kernel_size_t date_len; /**< Length of date buffer */ > > char __user *date; /**< User-space buffer to hold date */ > > - size_t desc_len; /**< Length of desc buffer */ > > + __kernel_size_t desc_len; /**< Length of desc buffer */ > > char __user *desc; /**< User-space buffer to hold desc */ > > }; > > > > @@ -143,7 +143,7 @@ struct drm_version { > > * \sa drmGetBusid() and drmSetBusId(). > > */ > > struct drm_unique { > > - size_t unique_len; /**< Length of unique */ > > + __kernel_size_t unique_len; /**< Length of unique */ > As the file is used by other platforms than Linux this change will > break them. Can you add a typedef similar to how __u8 and friends are > handled at the top of the file. Yes, I added typedef size_t __kernel_size_t; for other platforms. -Mikko