From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752579AbbHaHZm (ORCPT ); Mon, 31 Aug 2015 03:25:42 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:39651 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085AbbHaHZl (ORCPT ); Mon, 31 Aug 2015 03:25:41 -0400 Date: Mon, 31 Aug 2015 09:25:30 +0200 From: Sascha Hauer To: Daniel Kurtz Cc: Punit Agrawal , linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin , "linux-kernel@vger.kernel.org" , linux-mediatek@lists.infradead.org, Sasha Hauer , Matthias Brugger , "open list:OPEN FIRMWARE AND..." , Mark Rutland , Rob Herring Subject: Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Message-ID: <20150831072530.GD18700@pengutronix.de> References: <1440657677-2890-1-git-send-email-s.hauer@pengutronix.de> <1440657677-2890-2-git-send-email-s.hauer@pengutronix.de> <9hh1tepj6i4.fsf@e105922-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:24:39 up 67 days, 1:46, 105 users, load average: 0.09, 0.12, 0.13 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 28, 2015 at 10:23:15AM +0800, Daniel Kurtz wrote: > On Thu, Aug 27, 2015 at 7:49 PM, Punit Agrawal wrote: > > [ + device tree folks ] > > > > Hi Sascha, > > > > When introducing a new binding, it is a good idea to get reviews from > > the device tree maintainers. I've added a few folks here. Please keep > > them in the loop for future postings. > > > > Sascha Hauer writes: > > > >> Signed-off-by: Sascha Hauer > >> Reviewed-by: Daniel Kurtz > > > > Please add a commit log. > > > >> --- > >> .../bindings/thermal/mediatek-thermal.txt | 38 ++++++++++++++++++++++ > >> include/dt-bindings/thermal/mt8173.h | 13 ++++++++ > >> 2 files changed, 51 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > >> create mode 100644 include/dt-bindings/thermal/mt8173.h > >> > >> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > >> new file mode 100644 > >> index 0000000..1697375 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > >> @@ -0,0 +1,38 @@ > >> +* Mediatek Thermal > >> + > >> +This describes the device tree binding for the Mediatek thermal controller > >> +which measures the on-SoC temperatures. This device does not have its own ADC, > >> +instead it directly controls the AUXADC via AHB bus accesses. For this reason > >> +this device needs phandles to the AUXADC. Also it controls a mux in the > >> +apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS > >> +is also needed. > >> + > >> +Required properties: > >> +- compatible: "mediatek,mt8173-thermal" > >> +- reg: Address range of the thermal controller > >> +- interrupts: IRQ for the thermal controller > >> +- clocks, clock-names: Clocks needed for the thermal controller. required > >> + clocks are: > >> + "therm": Main clock needed for register access > >> + "auxadc": The AUXADC clock > >> +- resets: Reference to the reset controller controlling the thermal controller. > >> +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses > >> +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller. > >> +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See > >> + include/dt-bindings/thermal/mt8173.h for valid sensor > >> + numbers. > >> + > >> +Example: > >> + > >> + thermal: thermal@1100b000 { > >> + #thermal-sensor-cells = <1>; > >> + compatible = "mediatek,mt8173-thermal"; > >> + reg = <0 0x1100b000 0 0x1000>; > >> + interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>; > >> + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; > >> + clock-names = "therm", "auxadc"; > >> + resets = <&pericfg MT8173_PERI_THERM_SW_RST>; > >> + reset-names = "therm"; > >> + mediatek,auxadc = <&auxadc>; > >> + mediatek,apmixedsys = <&apmixedsys>; > >> + }; > >> diff --git a/include/dt-bindings/thermal/mt8173.h b/include/dt-bindings/thermal/mt8173.h > >> new file mode 100644 > >> index 0000000..692e74c > >> --- /dev/null > >> +++ b/include/dt-bindings/thermal/mt8173.h > >> @@ -0,0 +1,13 @@ > >> +/* > >> + * This header provides constants for mediatek,mt8173-thermal > >> + */ > >> + > >> +#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H > >> +#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H > >> + > >> +#define MT8173_THERMAL_ZONE_CA53 0 > >> +#define MT8173_THERMAL_ZONE_CA57 1 > >> +#define MT8173_THERMAL_ZONE_GPU 2 > >> +#define MT8173_THERMAL_ZONE_CORE 3 > >> + > >> +#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */ > > > > The constants in this include are not used in the patchset. Please drop > > this hunk and introduce it when you use it. > > These constants are part of the devicetree ABI, and I believe they > should be included with the binding. Yes, that's what I was told for other series. > To make this more concrete, I think these constants could be used as > array indices when initializing the corresponding banks of "bank_data" > in patch 2 (like you do when initializing scp_domain_data in the > scpsys driver). Good idea, will do that in the next round. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |