From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932166AbbIBTR5 (ORCPT ); Wed, 2 Sep 2015 15:17:57 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:46073 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753060AbbIBTRz (ORCPT ); Wed, 2 Sep 2015 15:17:55 -0400 Date: Wed, 2 Sep 2015 22:17:51 +0300 From: Mikko Rapeli To: Emil Velikov Cc: "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , linux-api@vger.kernel.org Subject: Re: [PATCH 10/98] via_drm.h: hide struct via_file_private in userspace Message-ID: <20150902191751.GY9187@lakka.kapsi.fi> References: <1433000370-19509-1-git-send-email-mikko.rapeli@iki.fi> <1433000370-19509-11-git-send-email-mikko.rapeli@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2001:1bc8:1004::1 X-SA-Exim-Mail-From: mikko.rapeli@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 03, 2015 at 05:50:22PM +0100, Emil Velikov wrote: > Hi Mikko, > > On 30 May 2015 at 16:38, Mikko Rapeli wrote: > > Fixes compiler error since list_head is not exported to userspace headers. > > > > Signed-off-by: Mikko Rapeli > > --- > > include/uapi/drm/via_drm.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/uapi/drm/via_drm.h b/include/uapi/drm/via_drm.h > > index 791531e..34ce658 100644 > > --- a/include/uapi/drm/via_drm.h > > +++ b/include/uapi/drm/via_drm.h > > @@ -272,8 +272,10 @@ typedef struct drm_via_dmablit { > > drm_via_blitsync_t sync; > > } drm_via_dmablit_t; > > > > +#ifdef __KERNEL__ > > struct via_file_private { > > struct list_head obj_list; > > }; > > +#endif > > > We might want to follow the example of other drivers (i915) and move > it to drivers/gpu/drm/via_drv.h, There are two users of this struct > (via_drv.c and via_mm.c), and each one explicitly includes the header. > How does that sound ? > > Same suggestion goes for the equivalent sis patch. Thanks, moved both of the file_private definitions to the driver headers. -Mikko