From: Christoffer Dall <christoffer.dall@linaro.org>
To: Eric Auger <eric.auger@linaro.org>
Cc: eric.auger@st.com, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
marc.zyngier@arm.com, alex.williamson@redhat.com,
feng.wu@intel.com, linux-kernel@vger.kernel.org,
patches@linaro.org, pbonzini@redhat.com
Subject: Re: [PATCH v3 06/10] VFIO: platform: add irq bypass producer management
Date: Wed, 2 Sep 2015 21:32:58 +0200 [thread overview]
Message-ID: <20150902193258.GU10991@cbox> (raw)
In-Reply-To: <1439212864-12954-7-git-send-email-eric.auger@linaro.org>
On Mon, Aug 10, 2015 at 03:21:00PM +0200, Eric Auger wrote:
> This patch populates the IRQ bypass callacks:
> - stop/start producer simply consist in disabling/enabling the host irq
> - add/del consumer: basically set the automasked flag to false/true
>
> Signed-off-by: Eric Auger <eric.auger@linaro.org>
>
> ---
> v2 -> v3:
> - vfio_platform_irq_bypass_add_consumer now returns an error in case
> the IRQ is recognized as active
> - active boolean not set anymore
> - do not VFIO mask the IRQ anymore on unforward
>
> v1 -> v2:
> - device handle caching in vfio_platform_device is introduced in a
> separate patch
> - use container_of
> ---
> drivers/vfio/platform/vfio_platform_irq.c | 23 ++++++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/platform/vfio_platform_irq.c b/drivers/vfio/platform/vfio_platform_irq.c
> index efaee58..400a188 100644
> --- a/drivers/vfio/platform/vfio_platform_irq.c
> +++ b/drivers/vfio/platform/vfio_platform_irq.c
> @@ -224,23 +224,44 @@ static int vfio_platform_is_active(struct vfio_platform_irq *irq)
>
> static void vfio_platform_irq_bypass_stop(struct irq_bypass_producer *prod)
> {
> + disable_irq(prod->irq);
> }
>
> static void vfio_platform_irq_bypass_start(struct irq_bypass_producer *prod)
> {
> + enable_irq(prod->irq);
> }
>
> static int vfio_platform_irq_bypass_add_consumer(
> struct irq_bypass_producer *prod,
> struct irq_bypass_consumer *cons)
> {
> - return 0;
> + struct vfio_platform_irq *irq =
> + container_of(prod, struct vfio_platform_irq, producer);
> +
> + /*
> + * if the IRQ is active at irqchip level or VFIO (auto)masked
If masked by VFIO?
> + * this means the host IRQ is already under injection in the
> + * guest and this not safe to change the forwarding state at
> + * that stage.
is this really specifically bound to guests?
> + * It is not possible to differentiate user-space masking
> + * from auto-masking, leading to possible false detection of
> + * active state.
ok, what is the consequence of that?
> + */
> + if (vfio_platform_is_active(irq))
> + return -EAGAIN;
> +
> + return vfio_platform_set_automasked(irq, false);
> }
>
> static void vfio_platform_irq_bypass_del_consumer(
> struct irq_bypass_producer *prod,
> struct irq_bypass_consumer *cons)
> {
> + struct vfio_platform_irq *irq =
> + container_of(prod, struct vfio_platform_irq, producer);
> +
> + vfio_platform_set_automasked(irq, true);
> }
>
> static int vfio_set_trigger(struct vfio_platform_device *vdev, int index,
> --
> 1.9.1
>
next prev parent reply other threads:[~2015-09-02 19:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 13:20 [PATCH v3 00/10] ARM IRQ forward control based on IRQ bypass manager Eric Auger
2015-08-10 13:20 ` [PATCH v3 01/10] VFIO: platform: registration of a dummy IRQ bypass producer Eric Auger
2015-08-12 18:56 ` Alex Williamson
2015-08-17 15:17 ` Eric Auger
2015-08-10 13:20 ` [PATCH v3 02/10] VFIO: platform: test forwarded state when selecting the IRQ handler Eric Auger
2015-08-10 13:20 ` [PATCH v3 03/10] VFIO: platform: single handler using function pointer Eric Auger
2015-08-12 18:56 ` Alex Williamson
2015-08-17 15:25 ` Eric Auger
2015-08-10 13:20 ` [PATCH v3 04/10] VFIO: platform: add vfio_platform_set_automasked Eric Auger
2015-08-12 18:56 ` Alex Williamson
2015-08-17 15:38 ` Eric Auger
2015-08-18 17:44 ` Alex Williamson
2015-08-31 11:43 ` Antonios Motakis
2015-08-31 14:54 ` Alex Williamson
2015-08-10 13:20 ` [PATCH v3 05/10] VFIO: platform: add vfio_platform_is_active Eric Auger
2015-08-12 18:56 ` Alex Williamson
2015-08-17 15:39 ` Eric Auger
2015-09-02 19:29 ` Christoffer Dall
2015-08-10 13:21 ` [PATCH v3 06/10] VFIO: platform: add irq bypass producer management Eric Auger
2015-08-12 18:56 ` Alex Williamson
2015-08-17 15:51 ` Eric Auger
2015-09-02 19:32 ` Christoffer Dall [this message]
2015-08-10 13:21 ` [PATCH v3 07/10] KVM: arm/arm64: vgic: Allow HW interrupts for non-shared devices Eric Auger
2015-09-02 19:42 ` Christoffer Dall
2015-09-08 12:04 ` Eric Auger
2015-09-14 10:59 ` Christoffer Dall
2015-09-09 8:41 ` Eric Auger
2015-09-14 11:11 ` Christoffer Dall
2015-08-10 13:21 ` [PATCH v3 08/10] KVM: arm/arm64: vgic: support irqfd injection of a forwarded IRQ Eric Auger
2015-08-10 13:21 ` [PATCH v3 09/10] KVM: arm/arm64: vgic: forwarding control Eric Auger
2015-09-02 19:58 ` Christoffer Dall
2015-09-14 9:29 ` Eric Auger
2015-09-14 11:24 ` Christoffer Dall
2015-08-10 13:21 ` [PATCH v3 10/10] KVM: arm/arm64: implement IRQ bypass consumer functions Eric Auger
2015-09-02 19:58 ` [PATCH v3 00/10] ARM IRQ forward control based on IRQ bypass manager Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902193258.GU10991@cbox \
--to=christoffer.dall@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=eric.auger@linaro.org \
--cc=eric.auger@st.com \
--cc=feng.wu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).