From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758264AbbIDMC1 (ORCPT ); Fri, 4 Sep 2015 08:02:27 -0400 Received: from mail.skyhub.de ([78.46.96.112]:59084 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753790AbbIDMCY (ORCPT ); Fri, 4 Sep 2015 08:02:24 -0400 Date: Fri, 4 Sep 2015 14:02:38 +0200 From: Borislav Petkov To: Thomas Gleixner Cc: "Richard W.M. Jones" , Chuck Ebbert , linux-kernel@vger.kernel.org, x86@kernel.org, Ingo Molnar , "H. Peter Anvin" Subject: Re: [BUG 4.2-rc8] Interrupt occurs while apply_alternatives() is patching the handler Message-ID: <20150904120238.GB23550@nazgul.tnic> References: <20150830223757.6e4c5c02@as> <20150901062022.GA19002@redhat.com> <20150903085046.GA19397@nazgul.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2015 at 12:41:47PM +0200, Thomas Gleixner wrote: > Nah. I rather put the local_irq_save into optimize_nops(). All other > callers of add_nops() are operating on a buffer and use text_poke > after that. Aside of that optimize_nops() is missing a sync_core(). Whoops. > Updated patch below. Looks good, thanks. Hrrm, maybe optimize_nops() should work on a buffer and do text_poke_early() too at the end, so that it doesn't differ from all the other paths changing kernel text. So as to stuff like that doesn't get missed next time I'm touching it. But with your way we don't need the additional buffer. I guess your solution is better resource-wise. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --