From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751469AbbIJA5j (ORCPT ); Wed, 9 Sep 2015 20:57:39 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51105 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752780AbbIJA5Z (ORCPT ); Wed, 9 Sep 2015 20:57:25 -0400 Date: Wed, 9 Sep 2015 17:57:22 -0700 From: Stephen Boyd To: Rob Herring Cc: Lee Jones , Viresh Kumar , Nishanth Menon , kernel@stlinux.com, "linux-pm@vger.kernel.org" , Dmitry Eremin-Solenikov , Rafael Wysocki , "linux-kernel@vger.kernel.org" , Sebastian Reichel , "devicetree@vger.kernel.org" , Arnd Bergmann , Ajit Pal Singh , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs Message-ID: <20150910005722.GA15099@codeaurora.org> References: <20150826120628.GZ19409@x1> <20150902080639.GA26744@linux> <20150909062722.GA5266@linux> <20150909075930.GB3260@x1> <20150909083031.GB5266@linux> <20150909133930.GE3260@x1> <20150909160212.GJ5266@linux> <20150909163620.GF3260@x1> <55F0C5AB.5060609@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55F0C5AB.5060609@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09, Rob Herring wrote: > On 09/09/2015 11:36 AM, Lee Jones wrote: > >>> Or have I got the wrong end of the stick? > >>> > >>> NB: Note the suggested new property names. > >> > >> Yeah, all looks fine to me. > > > > I think these names are better: > > > > opp-supply-range-name => opp-microvolt-names > > opp-cuts => opp-supported-hw > > > > Apart from that, the binding is starting to come together. > > > > Let's see what Rob and Stephen have to say about it. > > Seems reasonable to me. I think it will work for qcom use cases. We can collapse the tables down to one node and have speed bin and version as the opp-supported-hw property. The opp-microvolt-names property would be where we put the different voltage bins. What about the other properties like opp-microamp or opp-suspend? Will all of those also get *-names properties to index into them based on some string? I don't actually need those for my devices, but I'm just pointing it out in case someone else wants to compress tables but they have different microamps or clock latencies, etc. Finally, does this mean we will get rid of operating-points-names? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project