From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752925AbbIPKir (ORCPT ); Wed, 16 Sep 2015 06:38:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43528 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751648AbbIPKiq (ORCPT ); Wed, 16 Sep 2015 06:38:46 -0400 Date: Wed, 16 Sep 2015 18:39:17 +0800 From: Minfei Huang To: yanjiang.jin@windriver.com Cc: akpm@linux-foundation.org, chaowang@redhat.com, linux-kernel@vger.kernel.org, jinyanjiang@gmail.com Subject: Re: [PATCH] vmcore: replace Elf64_Ehdr/Elf32_Ehdr with elfhdr Message-ID: <20150916103917.GA32189@dhcp-128-25.nay.redhat.com> References: <1442372321-16334-1-git-send-email-yanjiang.jin@windriver.com> <1442372321-16334-2-git-send-email-yanjiang.jin@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442372321-16334-2-git-send-email-yanjiang.jin@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/16/15 at 10:58am, yanjiang.jin@windriver.com wrote: > From: Yanjiang Jin > > Function parse_crash_elf_headers() reads e_ident[EI_CLASS] then decides to > call parse_crash_elf64_headers() or parse_crash_elf32_headers(). > But this happens in run time, not compile time. So compiler will report > the below warning: > > In file included from include/linux/elf.h:4:0, > from fs/proc/vmcore.c:13: > fs/proc/vmcore.c: In function 'parse_crash_elf32_headers': > arch/mips/include/asm/elf.h:258:23: warning: initializatio > n from incompatible pointer type > struct elfhdr *__h = (hdr); \ > ^ How about converting the hdr to type elfhdr in above sentence, like following. struct elfhdr *__h = (struct elfhdr *)(hdr); Thanks Minfei > fs/proc/vmcore.c:1071:4: note: in expansion of macro 'elf_ > check_arch' > !elf_check_arch(&ehdr) || > ^ > > Signed-off-by: Yanjiang Jin > --- > fs/proc/vmcore.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c > index 4e61388..576bb26 100644 > --- a/fs/proc/vmcore.c > +++ b/fs/proc/vmcore.c > @@ -999,7 +999,7 @@ static void free_elfcorebuf(void) > static int __init parse_crash_elf64_headers(void) > { > int rc=0; > - Elf64_Ehdr ehdr; > + struct elfhdr ehdr; > u64 addr; > > addr = elfcorehdr_addr; > @@ -1055,7 +1055,7 @@ fail: > static int __init parse_crash_elf32_headers(void) > { > int rc=0; > - Elf32_Ehdr ehdr; > + struct elfhdr ehdr; > u64 addr; > > addr = elfcorehdr_addr;