From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753693AbbIQHOz (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Sep 2015 03:14:55 -0400
Received: from mail.skyhub.de ([78.46.96.112]:56483 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752942AbbIQHOx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Sep 2015 03:14:53 -0400
Date: Thu, 17 Sep 2015 09:15:04 +0200
From: Borislav Petkov <bp@alien8.de>
To: Josh Boyer <jwboyer@fedoraproject.org>,
        Greg KH <gregkh@linuxfoundation.org>
Cc: Philip =?utf-8?Q?M=C3=BCller?= <philm@manjaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Guenter Roeck <linux@roeck-us.net>, manjaro-dev@manjaro.org,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Andre Przywara <andre.przywara@arm.com>, Borislav Petkov <bp@suse.de>
Subject: Re: [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs
 code to generic infrastructure' on AMD i686
Message-ID: <20150917071504.GA12316@nazgul.tnic>
References: <55B16967.1040609@manjaro.org>
 <55B47BB8.6080202@manjaro.org>
 <alpine.DEB.2.11.1507261012480.18576@nanos>
 <20150726084154.GA14829@nazgul.tnic>
 <55B4BC7F.1060402@manjaro.org>
 <20150726144244.GA15550@nazgul.tnic>
 <CA+5PVA51W9EwDKCx1u-ONA_g-zVuhSKf9ux8wCTQbviBH5qTog@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CA+5PVA51W9EwDKCx1u-ONA_g-zVuhSKf9ux8wCTQbviBH5qTog@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 16, 2015 at 07:52:47PM -0400, Josh Boyer wrote:
> On Sun, Jul 26, 2015 at 10:42 AM, Borislav Petkov <bp@alien8.de> wrote:
> > On Sun, Jul 26, 2015 at 12:54:55PM +0200, Philip Müller wrote:
> >> I can confirm your patch working. However, it might be good to use yours
> >> and Thomas' in combination to solve this properly.
> >
> > Please do not top-post.
> >
> > We could use Thomas' too although from looking at it,
> > detect_cache_attributes() allocates a per-CPU per_cpu_cacheinfo thing
> > for each CPU. By the time we hit cache_shared_cpu_map_remove() in
> > free_cache_attributes(), those per_cpu_cacheinfo(cpu) things are still
> > allocated. We kfree them in the next step only.
> >
> > But I like the moving of the check from the CPU hotplug callback to
> > free_cache_attributes().
> >
> > So I'll merge the two patches and write up a proper commit message,
> > unless someone objects.
> >
> > I'll add your Tested-by too.
> 
> Did this actually happen?  I don't see either fix in Linus' tree yet,
> the merge window is closed, and the bug happens on 4.1 and 4.2 stable
> kernels..

Greg wanted to pick it up...

Greg, what's up?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--