From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbbIQJvp (ORCPT ); Thu, 17 Sep 2015 05:51:45 -0400 Received: from TYO202.gate.nec.co.jp ([210.143.35.52]:40347 "EHLO tyo202.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbbIQJvo (ORCPT ); Thu, 17 Sep 2015 05:51:44 -0400 From: Naoya Horiguchi To: =?utf-8?B?UMOhZHJhaWcgQnJhZHk=?= CC: Andrew Morton , David Rientjes , =?utf-8?B?SsO2cm4gRW5nZWw=?= , Mike Kravetz , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Naoya Horiguchi Subject: Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps Thread-Topic: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps Thread-Index: AQHQ2yHn+YywyXZF3USjpses11xHFp4vzECAgAAPCoCAAElZAIAANBwAgAAQwICAD6LKAA== Date: Thu, 17 Sep 2015 09:39:15 +0000 Message-ID: <20150917093914.GA18723@hori1.linux.bs1.fc.nec.co.jp> References: <20150812000336.GB32192@hori1.linux.bs1.fc.nec.co.jp> <1440059182-19798-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1440059182-19798-2-git-send-email-n-horiguchi@ah.jp.nec.com> <55ECE891.7030309@draigBrady.com> <20150907022343.GB6448@hori1.linux.bs1.fc.nec.co.jp> <20150907064614.GB7229@hori1.linux.bs1.fc.nec.co.jp> <55ED5E6C.6000102@draigBrady.com> <55ED6C79.6030000@draigBrady.com> In-Reply-To: <55ED6C79.6030000@draigBrady.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.128.101.27] Content-Type: text/plain; charset="utf-8" Content-ID: <0AAEA283A6BE174BA64F0DB0054021A5@gisp.nec.co.jp> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t8H9poXE008447 On Mon, Sep 07, 2015 at 11:52:41AM +0100, Pádraig Brady wrote: ... > > By the same argument I presume the existing THP "AnonHugePages" smaps field > is not accounted for in the {Private,Shared}_... fields? > I.E. AnonHugePages may also benefit from splitting to Private/Shared? smaps_pmd_entry() not only increments mss->anonymous_thp, but also calls smaps_account() which updates mss->anonymous, mss->referenced and mss->{shared,private}_{clean,dirty}, so thp's shared/private characteristic is included in other existing fields. I think that even if we know the thp-specific shared/private profiles, it might be hard to do something beneficial using that information, so I feel keeping this field as-is is ok for now. Thanks, Naoya Horiguchi{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I