From: Catalin Marinas <catalin.marinas@arm.com>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, steve.capper@arm.com,
dwoods@ezcip.com, linux-kernel@vger.kernel.org,
will.deacon@arm.com, shijie.huang@arm.com
Subject: Re: [PATCH 2/7] arm64: Shorten lines which exceed 80 characters
Date: Thu, 17 Sep 2015 10:45:34 +0100 [thread overview]
Message-ID: <20150917094533.GL25444@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <1442430186-9083-3-git-send-email-jeremy.linton@arm.com>
On Wed, Sep 16, 2015 at 02:03:01PM -0500, Jeremy Linton wrote:
> PTE definitions in this file exceed 80 characters
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
> arch/arm64/include/asm/pgtable-hwdef.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/include/asm/pgtable-hwdef.h b/arch/arm64/include/asm/pgtable-hwdef.h
> index 24154b0..4489cf6 100644
> --- a/arch/arm64/include/asm/pgtable-hwdef.h
> +++ b/arch/arm64/include/asm/pgtable-hwdef.h
> @@ -99,14 +99,14 @@
> #define PTE_TYPE_FAULT (_AT(pteval_t, 0) << 0)
> #define PTE_TYPE_PAGE (_AT(pteval_t, 3) << 0)
> #define PTE_TABLE_BIT (_AT(pteval_t, 1) << 1)
> -#define PTE_USER (_AT(pteval_t, 1) << 6) /* AP[1] */
> -#define PTE_RDONLY (_AT(pteval_t, 1) << 7) /* AP[2] */
> -#define PTE_SHARED (_AT(pteval_t, 3) << 8) /* SH[1:0], inner shareable */
> -#define PTE_AF (_AT(pteval_t, 1) << 10) /* Access Flag */
> -#define PTE_NG (_AT(pteval_t, 1) << 11) /* nG */
> -#define PTE_DBM (_AT(pteval_t, 1) << 51) /* Dirty Bit Management */
> -#define PTE_PXN (_AT(pteval_t, 1) << 53) /* Privileged XN */
> -#define PTE_UXN (_AT(pteval_t, 1) << 54) /* User XN */
> +#define PTE_USER (_AT(pteval_t, 1) << 6) /* AP[1] */
> +#define PTE_RDONLY (_AT(pteval_t, 1) << 7) /* AP[2] */
> +#define PTE_SHARED (_AT(pteval_t, 3) << 8) /* inner shareable */
> +#define PTE_AF (_AT(pteval_t, 1) << 10) /* Access Flag */
> +#define PTE_NG (_AT(pteval_t, 1) << 11) /* nG */
> +#define PTE_DBM (_AT(pteval_t, 1) << 51) /* Dirty Bit Mgmt */
> +#define PTE_PXN (_AT(pteval_t, 1) << 53) /* Privileged XN */
> +#define PTE_UXN (_AT(pteval_t, 1) << 54) /* User XN */
I told you already ;), I'm not taking this patch. Some (of my) rules for
checkpatch usage:
1. Don't run it on existing code with the aim of fixing it
2. Existing coding style takes precedence over checkpatch warnings
(I have another rule but I don't want to impose it on anyone: I never
run checkpatch)
--
Catalin
next prev parent reply other threads:[~2015-09-17 9:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 19:02 [PATCH 0/7] arm64: Use contigous PTE bit for the kernel linear mapping Jeremy Linton
2015-09-16 19:03 ` [PATCH 1/7] arm64: Add contiguous page flag shifts and constants Jeremy Linton
2015-09-16 19:03 ` [PATCH 2/7] arm64: Shorten lines which exceed 80 characters Jeremy Linton
2015-09-17 9:45 ` Catalin Marinas [this message]
2015-09-16 19:03 ` [PATCH 3/7] arm64: PTE/PMD contiguous bit definition Jeremy Linton
2015-09-16 19:03 ` [PATCH 4/7] arm64: Macros to check/set/unset the contiguous bit Jeremy Linton
2015-09-16 19:03 ` [PATCH 5/7] arm64: Default kernel pages should be contiguous Jeremy Linton
2015-09-16 19:03 ` [PATCH 6/7] arm64: Make the kernel page dump utility aware of the CONT bit Jeremy Linton
2015-09-18 7:02 ` Huang Shijie
2015-09-18 8:35 ` Huang Shijie
2015-09-16 19:03 ` [PATCH 7/7] arm64: Mark kernel page ranges contiguous Jeremy Linton
2015-09-17 17:23 ` Steve Capper
2015-09-17 17:33 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150917094533.GL25444@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=dwoods@ezcip.com \
--cc=jeremy.linton@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shijie.huang@arm.com \
--cc=steve.capper@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).