From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754069AbbIQJ7M (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Sep 2015 05:59:12 -0400
Received: from foo.stuge.se ([212.116.89.98]:54173 "EHLO foo.stuge.se"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753671AbbIQJ7J (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Sep 2015 05:59:09 -0400
Message-ID: <20150917095906.28220.qmail@stuge.se>
Date: Thu, 17 Sep 2015 11:59:06 +0200
From: Peter Stuge <peter@stuge.se>
To: WEN Pingbo <pingbo.wen@linaro.org>
Cc: linux-usb@vger.kernel.org, Y2038 <y2038@lists.linaro.org>,
        linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
        Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH V2] dummy_hcd: replace timeval with timespec64
Mail-Followup-To: WEN Pingbo <pingbo.wen@linaro.org>,
	linux-usb@vger.kernel.org, Y2038 <y2038@lists.linaro.org>,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Felipe Balbi <balbi@ti.com>
References: <2640620.MF43KccxAS@wuerfel> <1442459389-11171-1-git-send-email-pingbo.wen@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1442459389-11171-1-git-send-email-pingbo.wen@linaro.org>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

WEN Pingbo wrote:
> +++ b/drivers/usb/gadget/udc/dummy_hcd.c
> @@ -833,10 +833,10 @@ static const struct usb_ep_ops dummy_ep_ops = {
>  /* there are both host and device side versions of this call ... */
>  static int dummy_g_get_frame(struct usb_gadget *_gadget)
>  {
> -	struct timeval	tv;
> +	struct timespec64 tv;

tv is very often used for timeval structs.

I suggest also changing the variable name, for example to ts, to
avoid some possible confusion.


//Peter