From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751527AbbIQLOa (ORCPT ); Thu, 17 Sep 2015 07:14:30 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35407 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750974AbbIQLO3 (ORCPT ); Thu, 17 Sep 2015 07:14:29 -0400 Date: Thu, 17 Sep 2015 13:14:26 +0200 From: Luis de Bethencourt To: Stephen Rothwell Cc: Tejun Heo , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build failure after merge of the libata tree Message-ID: <20150917111426.GA11478@goodgumbo.baconseed.org> References: <20150917140336.63c2d09c@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150917140336.63c2d09c@canb.auug.org.au> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2015 at 02:03:36PM +1000, Stephen Rothwell wrote: > Hi Tejun, > > After merging the libata tree, today's linux-next build (powercp > allmodconfig) failed like this: > > drivers/ata/pata_macio.c:1347:1: error: 'pata_macio_patch' undeclared here (not in a function) > drivers/ata/pata_macio.c:1347:1: error: '__mod_of__pata_macio_patch_device_table' aliased to undefined symbol 'pata_macio_patch' > > Caused by commit > > 5d8619769cf5 ("ata: pata_macio: Fix module autoload for OF platform driver") > > A simple typo ("patch" v "match"), but clearly never build tested. > > Only found after the release. > > -- > Cheers, > Stephen Rothwell sfr@canb.auug.org.au Sorry, this was my fault. When I created the second version of the patch, based on -stable instead of -next the typo creeped in and I didn't test properly. Sending a correct version of the patch now. Apologies, Luis