From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751714AbbIQLRw (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Sep 2015 07:17:52 -0400
Received: from mail-pa0-f44.google.com ([209.85.220.44]:36297 "EHLO
	mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751604AbbIQLRu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Sep 2015 07:17:50 -0400
Date: Thu, 17 Sep 2015 16:47:40 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Archit Taneja <architt@codeaurora.org>
Cc: Ingo Molnar <mingo@kernel.org>, Daniel Vetter <daniel.vetter@ffwll.ch>,
        Dave Airlie <airlied@gmail.com>, David Airlie <airlied@linux.ie>,
        LKML <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Archit Taneja <archit@ti.com>
Subject: Re: [PATCH] drm/mgag200: Fix calling drm_fb_helper_fini() twice
Message-ID: <20150917111740.GD20514@sudip-pc>
References: <1441627110-13783-1-git-send-email-sudipm.mukherjee@gmail.com>
 <20150913093607.GA6074@gmail.com>
 <CAPM=9tzwUOKzJwvH1CO2u7YDCUoai3XxAdWZzA2_c44e4XfEEA@mail.gmail.com>
 <CAPM=9tyRJ-vWqxTMHeUXDm7+2RH8gtPwvx-rRsSOweB4CLw96w@mail.gmail.com>
 <55F6E68D.8070800@codeaurora.org>
 <20150916094648.GA11711@gmail.com>
 <20150917083442.GA24766@gmail.com>
 <55FA9BDD.7010603@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55FA9BDD.7010603@codeaurora.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 17, 2015 at 04:24:21PM +0530, Archit Taneja wrote:
> 
> 
> On 9/17/2015 2:04 PM, Ingo Molnar wrote:
> >
> >
> >* Ingo Molnar <mingo@kernel.org> wrote:
> >
> >
> >
> >>So this patch was whitespace damaged - I applied it by hand and made the commit
> >
> >>below. This has solved the crash, thanks Archit!
> >
> >
> >
> >Spoke too soon - the attached (allyesconfig-ish) config still crashes, first there
> >
> >are a handful of kobject debug warnings, then:
> 
> The error handling in the driver is bad. The main problem is that
> the driver_load op calls mgag200_driver_unload if anything fails,
> which doesn't work well if driver_load fails mid way.
mgag200_driver_unload is trying to unload everything evenif that has not
succeeded in initializing. Here the ttm failed to initialize but
still mgag200_mm_fini was called to unload it.

regards
sudip