From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751782AbbIQL3K (ORCPT ); Thu, 17 Sep 2015 07:29:10 -0400 Received: from down.free-electrons.com ([37.187.137.238]:58827 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751618AbbIQL3I (ORCPT ); Thu, 17 Sep 2015 07:29:08 -0400 Date: Thu, 17 Sep 2015 13:29:05 +0200 From: Maxime Ripard To: yassinjaffer@gmail.com Cc: linux-sunxi@googlegroups.com, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC Message-ID: <20150917112905.GC4684@lukather> References: <1442325957-10102-1-git-send-email-yassinjaffer@gmail.com> <1442325957-10102-3-git-send-email-yassinjaffer@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fzZfjcV6kaBgkq89" Content-Disposition: inline In-Reply-To: <1442325957-10102-3-git-send-email-yassinjaffer@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fzZfjcV6kaBgkq89 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Yassin, On Wed, Sep 16, 2015 at 12:05:55AM +1000, yassinjaffer@gmail.com wrote: > From: Yassin Jaffer >=20 > Add Keypad controller node definition to the A20 SoC. >=20 > Signed-off-by: Yassin Jaffer > --- > arch/arm/boot/dts/sun7i-a20.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a= 20.dtsi > index 333604a..35cc8d0 100644 > --- a/arch/arm/boot/dts/sun7i-a20.dtsi > +++ b/arch/arm/boot/dts/sun7i-a20.dtsi > @@ -1198,6 +1198,15 @@ > status =3D "disabled"; > }; > =20 > + kp: kp@01c23000 { The node name should reflect the class of the device. keypad@01c23000 would be better for example. It looks good otherwise. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --fzZfjcV6kaBgkq89 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV+qQBAAoJEBx+YmzsjxAg7iMQAI2VEmgYFxuZQaUP5QA1WxXN C+YYBbwTG/8UkGLK/Y3DJXx4KIkH8xgaWH6P2sXFxl1Nj+Ahsp5oTIhhgoqWJ6QR WMHetZSYAQaSMDBjUaimwt3TVULZ1HHdFXqhdimBiNcK+8RkcC42Z5uwONeU0RxR TP6An63/CThf6/domFRjK1KU6LkZsWVPI6f9wQNXVxJUny2qpELV46fUWnImO2yS Qca7uUNyk/EioDdUcpOqHWr0IkCdHtd2Fes0YFhlBtiht7d5/N8afe9Gv1vtupPU iKSToopK4/ym/CPVpqiFgpEZW5UjcJQSkxbXCco9vFyKw/zz6MyVz9I3/28k8Sji KPDvJsMXHzyPoX9KkjNKhlIqtRR0tOQ2WeVDMJUt6Hmq57uM4b57dW3Hl6vCC+wv 8uV4L/e/RTYsEszc/8oEBj+KWCYjI7nskmOxGlUNppGjm51tzGwZLRJ/IyVNbrKp G6jBtnTS8CzdC7NbSmnT1JU/OalqWLUl6MvHS/IRHkKXmpyNRaOD0z/vHe5EoiCy ETnVyRqKvLXM/mYURCmYyxOtcZlwXDoFirzJ9puU6habqbyA5rXzco8jnnlDfHBP j86oAaTaSD8IzPvXgvJPoGJ4BwZqRIMcdWlNRicDNa0L34tOmyX7lXXkYC7xKYtO X7ANklZNoWM6wQzNtP7e =gs0v -----END PGP SIGNATURE----- --fzZfjcV6kaBgkq89--