From: Greg KH <gregkh@linuxfoundation.org>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Dmitry Vyukov <dvyukov@google.com>, Jiri Slaby <jslaby@suse.com>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Jiri Slaby <jslaby@suse.cz>,
Andrey Konovalov <andreyknvl@google.com>,
Kostya Serebryany <kcc@google.com>,
Alexander Potapenko <glider@google.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Hans Boehm <hboehm@google.com>
Subject: Re: [PATCH v2] tty: fix data race in flush_to_ldisc
Date: Thu, 17 Sep 2015 06:54:49 -0700 [thread overview]
Message-ID: <20150917135449.GB26495@kroah.com> (raw)
In-Reply-To: <CAKU3ayVt3Jb3tH8Mq3udM7VpChhN_v1s0-h8E66rdj4u6QcOBg@mail.gmail.com>
On Thu, Sep 17, 2015 at 09:18:11AM -0400, Peter Hurley wrote:
> On Thu, Sep 17, 2015 at 8:53 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Thu, Sep 17, 2015 at 12:39:36PM +0200, Dmitry Vyukov wrote:
> >> flush_to_ldisc reads port->itty and checks that it is not NULL,
> >> concurrently release_tty sets port->itty to NULL. It is possible
> >> that flush_to_ldisc loads port->itty once, ensures that it is
> >> not NULL, but then reloads it again and uses. The second load
> >> can already return NULL, which will cause a crash.
> >>
> >> Use READ_ONCE to read port->itty.
> >>
> >> The data race was found with KernelThreadSanitizer (KTSAN).
> >>
> >> Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
> >
> > You sent 3 patches here, but no hint as to what order they need to be
> > applied in. Please resend them as a patch series (i.e. 1/3, 2/3, 3/3)
> > so they can be applied correctly.
>
> Greg,
>
> I don't think these 3 patches are dependent on each other; I think they
> can be applied in any order.
How do I know that? :)
prev parent reply other threads:[~2015-09-17 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 10:39 [PATCH v2] tty: fix data race in flush_to_ldisc Dmitry Vyukov
2015-09-17 12:53 ` Greg KH
2015-09-17 13:18 ` Peter Hurley
2015-09-17 13:21 ` Dmitry Vyukov
2015-09-17 13:55 ` Greg KH
2015-09-17 13:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150917135449.GB26495@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=hboehm@google.com \
--cc=jslaby@suse.com \
--cc=jslaby@suse.cz \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).